Improve DockerHubListener comments
ClosedPublic
Actions

Authored by dereckson on Sep 21 2018, 12:13.

Tags

None

Referenced Files

	F47696283: D1785.id4526.diff
	Tue, Sep 1, 16:38

	F47691069: D1785.diff
	Tue, Sep 1, 15:26

	Unknown Object (File)
	Tue, Sep 1, 07:23

	Unknown Object (File)
	Tue, Sep 1, 01:45

	Unknown Object (File)
	Mon, Aug 31, 13:03

	Unknown Object (File)
	Mon, Aug 24, 04:02

	Unknown Object (File)
	Sun, Aug 23, 04:25

	Unknown Object (File)
	Sun, Aug 23, 04:25

View All Files

Subscribers

None

Details

Reviewers

dereckson

Maniphest Tasks

T959: Trigger Docker Hub build when source repository is updated

Commits

rNOTIF7f4a991d04e3: Improve DockerHubListener comments

Summary

Class comments were based on the Phabricator listener ones,
with some leftovers.

This is a follow-up for e4b94f5c52b9.

Ref T959.

Test Plan

no op

Diff Detail

Repository

rNOTIF Notifications center

Lint

Lint Passed

Unit

No Test Coverage

Branch

docker-comments (branched from master)

Build Status

Buildable 2771
Build 3019: arc lint + arc unit

Event Timeline

dereckson requested review of this revision.Sep 21 2018, 12:13

dereckson created this revision.

Harbormaster completed remote builds in B2771: Diff 4526.Sep 21 2018, 12:13

dereckson accepted this revision.Sep 21 2018, 12:19

This revision is now accepted and ready to land.Sep 21 2018, 12:19

Closed by commit rNOTIF7f4a991d04e3: Improve DockerHubListener comments (authored by dereckson). · Explain WhySep 21 2018, 12:19

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

app/

Listeners/

DockerHubListener.php

4 lines

Diff 4526

View Options

app/Listeners/DockerHubListener.php

Improve DockerHubListener commentsClosedPublicActions