Provide a void Services instance as fallback
ClosedPublic
Actions

Authored by dereckson on Jan 9 2016, 04:55.

Details

Reviewers

dereckson

Commits

Unknown Object (Diffusion Commit)
rNOTIF343dd7c666c2: Provide a void Services instance as fallback

Summary

The configuration key security.gate.credentials allows to define
a credentials.json file with the list of services credentials.

When the file doesn't exist, instead of deserializing this file,
we provide an empty Services instance.

This fixes a regression introduced at D180.

Test Plan

phpunit

Diff Detail

Repository

rNOTIF Notifications center

Lint

No Lint Coverage

Unit

No Test Coverage

Branch

services-without-config

Build Status

Buildable 247
Build 247: arc lint + arc unit

Event Timeline

dereckson updated this revision to Diff 466.Jan 9 2016, 04:55

dereckson retitled this revision from to Provide a void Services instance as fallback.

dereckson updated this object.

dereckson edited the test plan for this revision. (Show Details)

dereckson added a reviewer: dereckson.

dereckson accepted this revision.Jan 9 2016, 04:58

dereckson updated this object.

dereckson edited edge metadata.

This revision is now accepted and ready to land.Jan 9 2016, 04:58

Closed by commit rNOTIF343dd7c666c2: Provide a void Services instance as fallback (authored by dereckson, committed by dereckson). · Explain WhyJan 9 2016, 05:00

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

app/

Providers/

ServicesServiceProvider.php

8 lines

Diff 466

View Options

app/Providers/ServicesServiceProvider.php

Provide a void Services instance as fallbackClosedPublicActions