Tags

None

Referenced Files

	F35288072: D2278.id5738.diff
	Wed, Jul 8, 23:28

	F35288069: D2278.id5739.diff
	Wed, Jul 8, 23:28

	F35285514: D2278.id5737.diff
	Wed, Jul 8, 21:45

	F35285491: D2278.id5741.diff
	Wed, Jul 8, 21:45

	F35283067: D2278.id5740.diff
	Wed, Jul 8, 20:23

	F35282905: D2278.diff
	Wed, Jul 8, 20:21

	Unknown Object (File)
	Fri, Jul 3, 19:17

	Unknown Object (File)
	Fri, Jul 3, 14:42

View All Files

Subscribers

None

Details

Reviewers

dereckson

Commits

rKOT7292b54afb09: Detect when test suite runs with privileged access

Summary

When the test suite runs as root under Linux or FreeBSD,
or with elevated status ('runs as administrator') on Windows,
the process can see normally non-readable files.

As such, we skip the relevant tests.

Test Plan

Windows: runs in a regular console and a privileged console
Debian: runs as root, and with sudo -u nobody phpunit
FreeBSD: runs trim(shell_exec('id -u')) with psysh

Diff Detail

Repository

rKOT Keruald OmniTools

Lint

Lint Passed

Unit

Tests Passed

Branch

arcpatch-D2278

Build Status

Buildable 3539
Build 3788: arc lint + arc unit

Event Timeline

dereckson requested review of this revision.Mar 11 2020, 14:42

dereckson created this revision.

Harbormaster completed remote builds in B3537: Diff 5737.Mar 11 2020, 14:42

Tweak and document

Harbormaster completed remote builds in B3538: Diff 5738.Mar 11 2020, 19:27

We can try to use posix too

Harbormaster completed remote builds in B3539: Diff 5739.Mar 11 2020, 19:32

Exceptions, general case

Harbormaster completed remote builds in B3540: Diff 5740.Mar 11 2020, 19:38

dereckson accepted this revision.Mar 11 2020, 19:53

This revision is now accepted and ready to land.Mar 11 2020, 19:53

Closed by commit rKOT7292b54afb09: Detect when test suite runs with privileged access (authored by dereckson). · Explain WhyMar 11 2020, 19:54

This revision was automatically updated to reflect the committed changes.

dereckson added a commit: rKOT7292b54afb09: Detect when test suite runs with privileged access.

Detect when test suite runs with privileged access
ClosedPublic
Actions

Details

Diff Detail

Event Timeline

Revision Contents
Changeset List

Diff 5739

src/OS/CurrentOS.php

src/OS/CurrentProcess.php

tests/Reflection/CodeFileTest.php

Detect when test suite runs with privileged accessClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 5739

src/OS/CurrentOS.php

src/OS/CurrentProcess.php

tests/Reflection/CodeFileTest.php

Detect when test suite runs with privileged access
ClosedPublic
Actions

Revision Contents
Changeset List