Paths

Table of Contentst

Lazy evaluate default values
ClosedPublic
Actions

Authored by dereckson on May 30 2020, 22:52.

Tags

None

Referenced Files

	F44608100: D2289.diff
	Mon, Aug 17, 20:11

	F44551467: D2289.id5769.diff
	Mon, Aug 17, 14:33

	Unknown Object (File)
	Sun, Aug 16, 16:26

	Unknown Object (File)
	Sun, Aug 16, 12:46

	Unknown Object (File)
	Sun, Aug 16, 12:46

	Unknown Object (File)
	Sun, Aug 16, 09:47

	Unknown Object (File)
	Sun, Aug 16, 08:58

	Unknown Object (File)
	Sun, Aug 16, 06:30

View All Files

Subscribers

None

Details

Reviewers

amj
dereckson

Commits

rLF56b5eae8479a: Lazy evaluate default values

Summary

The unwrap_or_else method allows to pass a closure,
and so allows lazy evaluation of the argument.

Test Plan

println!("Mounting at {}", entry_point);

Diff Detail

Repository

rLF Limiting Factor

Lint

Lint Passed

Unit

No Test Coverage

Branch

fix-unwrap-or

Build Status

Buildable 3558
Build 3807: arc lint + arc unit

Event Timeline

dereckson requested review of this revision.May 30 2020, 22:52

dereckson created this revision.

Harbormaster completed remote builds in B3556: Diff 5767.May 30 2020, 22:52

I'm not sure the performance improvement justify a commit. These kind of optimization can probably be done by the compiler because String::from("/") have no side effect.

for DefaultConfig too

Harbormaster completed remote builds in B3558: Diff 5769.May 30 2020, 23:58

dereckson accepted this revision.Sep 24 2020, 20:05

This revision is now accepted and ready to land.Sep 24 2020, 20:05

Closed by commit rLF56b5eae8479a: Lazy evaluate default values (authored by dereckson). · Explain WhySep 24 2020, 20:06

This revision was automatically updated to reflect the committed changes.

dereckson added a commit: rLF56b5eae8479a: Lazy evaluate default values.

Revision Contents
Changeset List

Path

Size

src/

config.rs

6 lines

Diff 5769

View Options

Lazy evaluate default valuesClosedPublicActions