Page MenuHomeDevCentral

Avoid to compare shell_exec() result as false or null
ClosedPublic

Authored by dereckson on Jan 26 2022, 19:41.
Tags
None
Referenced Files
F12066103: D2486.id6267.diff
Tue, Sep 30, 06:00
Unknown Object (File)
Thu, Sep 25, 15:01
Unknown Object (File)
Wed, Sep 24, 22:43
Unknown Object (File)
Wed, Sep 24, 16:32
Unknown Object (File)
Tue, Sep 23, 06:01
Unknown Object (File)
Sun, Sep 21, 11:18
Unknown Object (File)
Fri, Sep 19, 09:37
Unknown Object (File)
Wed, Sep 17, 02:48
Subscribers
None

Details

Summary

When comparing the command output with a string,
shell_exec() can returns false or null.

If it returns null, trim will receives NULL value,
and that's behavior is deprecated under PHP 7.4+:

trim(null) would return:

Deprecated: trim(): Passing null to parameter #1 ($string)
of type string is deprecated

Diff Detail

Repository
rKOT Keruald OmniTools
Lint
Lint Skipped
Unit
Tests Skipped
Branch
shell_exec_can_return_false_or_null
Build Status
Buildable 3875
Build 4126: arc lint + arc unit

Event Timeline

dereckson created this revision.
This revision is now accepted and ready to land.Jan 26 2022, 19:42