Differential D34

Solve two nginx concurrent vhosts issue
ClosedPublic
Actions

Authored by Sandlayth on Nov 6 2015, 22:09.

Details

Reviewers

dereckson

Maniphest Tasks

T546: /etc/nginx/sites-enabled/default isn't deleted
T552: File not deleted

Commits

rDPHABcf3a8d39a6a0: Solve two nginx concurrent vhosts issue

Summary

Previously, this image added a new site vhost for Phabricator, and
removed the default vhost provided by nasqueron/nginx-php-fpm.

Instead, we overwrite the default with our own configuration.

This allows to avoid the two files to be present in the same image,
as Docker 1.3 to 1.8 doesn't seem to honour a rm command on an upper
layer than the actual file.

Fixes T546.

Test Plan

docker build --tag=nasqueron/phabricator .
docker run --rm nasqueron/phabricator cat /etc/nginx/sites-enabled/default

Diff Detail

Repository

rDPHAB Docker image for Phabricator

Lint

Lint Skipped

Unit

Tests Skipped

Event Timeline

Sandlayth updated this revision to Diff 69.Nov 6 2015, 22:09

Sandlayth retitled this revision from to Remove /etc/nginx/sites-enabled/default.

Sandlayth updated this object.

Sandlayth edited the test plan for this revision. (Show Details)

Sandlayth added a reviewer: dereckson.

Sandlayth set the repository for this revision to rDPHAB Docker image for Phabricator.

Sandlayth added a project: Nasqueron Docker deployment squad.

Sandlayth added a subscriber: Nasqueron Docker deployment squad.

Sandlayth added a task: T552: File not deleted.Nov 6 2015, 22:14

[ops@dwellers docker-phabricator]$ docker run -d nasqueron\phabricator ls /etc/nginx/sites-enabled/default
[ops@dwellers docker-phabricator]$ docker logs loving_meitner
/etc/nginx/sites-enabled/default

dereckson added a task: T546: /etc/nginx/sites-enabled/default isn't deleted.Nov 7 2015, 22:29