Page MenuHomeDevCentral

Propagate errors if we can't handle it in vault_get
ClosedPublic

Authored by dereckson on Apr 12 2023, 00:01.
Tags
None
Referenced Files
F53563325: D3003.id7668.diff
Sat, Oct 10, 21:35
F53546838: D3003.id7669.diff
Sat, Oct 10, 19:27
F53534730: D3003.diff
Sat, Oct 10, 17:43
F53492472: D3003.diff
Sat, Oct 10, 09:37
Unknown Object (File)
Tue, Oct 6, 20:42
Unknown Object (File)
Sun, Oct 4, 20:10
Unknown Object (File)
Sun, Oct 4, 16:01
Unknown Object (File)
Sat, Oct 3, 14:01
Subscribers
None

Details

Summary

When an error is caught in vault_get, it only handles the 403 case.

If vault is currently in 503 (still sealed for example), it does nothing,
so the return fails with can't read "credential": no such variable.

This change allows vault_get to propagate instead the error:
"Vault returned HTTP/1.1 503 Service Unavailable, 200 OK was expected."

Test Plan

Tested on Wearg

Diff Detail

Repository
rVIPER ViperServ scripts
Lint
No Lint Coverage
Unit
No Test Coverage
Branch
vault-unsealed
Build Status
Buildable 4749
Build 5030: arc lint + arc unit

Event Timeline

dereckson created this revision.
This revision is now accepted and ready to land.Apr 12 2023, 00:09