Page MenuHomeDevCentral
Differential D324

Tests for ProjectsMap
ClosedPublic
Actions

Authored by dereckson on Mar 3 2016, 17:42.
Tags
None
Referenced Files
F21389937: D324.id767.diff
Wed, Jan 21, 22:38
Unknown Object (File)
Tue, Jan 20, 22:19
Unknown Object (File)
Tue, Jan 20, 00:09
Unknown Object (File)
Sun, Jan 18, 07:31
Unknown Object (File)
Fri, Jan 16, 05:00
Unknown Object (File)
Thu, Jan 15, 15:12
Unknown Object (File)
Thu, Jan 15, 06:31
Unknown Object (File)
Thu, Jan 15, 04:41
View All Files
Subscribers
alken-orin

Details

Reviewers
dereckson
Commits
rNOTIFfea5b9c2d83f: Tests for ProjectsMap
Summary

We use the PhabricatorAPI mock which returns the three projects
of our Phabricator install to build a map we can test.

Test Plan

Run tests, check coverage.

Diff Detail

Repository
rNOTIF Notifications center
Lint
Lint Passed
Unit
Tests Passed
Branch
test/ProjectsMap

Event Timeline

dereckson updated this revision to Diff 766.Mar 3 2016, 17:42
dereckson retitled this revision from to Tests for ProjectsMap.
dereckson updated this object.
dereckson edited the test plan for this revision. (Show Details)
dereckson added a reviewer: dereckson.
dereckson updated this revision to Diff 767.Mar 3 2016, 17:46
dereckson edited edge metadata.

Fix @covers

alken-orin added a subscriber: alken-orin.Mar 3 2016, 17:55

Build started: https://ci.nasqueron.org/job/test-notifications-phab/112/ (console: https://ci.nasqueron.org/job/test-notifications-phab/112/console)

alken-orin added a comment.Mar 3 2016, 18:04

Build has FAILED

Link to build: https://ci.nasqueron.org/job/test-notifications-phab/112/
See console output for more information: https://ci.nasqueron.org/job/test-notifications-phab/112/console

alken-orin added a comment.Mar 3 2016, 18:04

Build started: https://ci.nasqueron.org/job/test-notifications-phab/113/ (console: https://ci.nasqueron.org/job/test-notifications-phab/113/console)

alken-orin added a comment.Mar 3 2016, 18:16

Build is green https://ci.nasqueron.org/job/test-notifications-phab/113/ for more details.

dereckson mentioned this in D325: Fix type error when data isn't cached in ProjectsMap.Mar 3 2016, 19:24
dereckson added a parent revision: D325: Fix type error when data isn't cached in ProjectsMap.Mar 3 2016, 19:25
dereckson mentioned this in rNOTIFb26c9938c1e5: Fix type error when data isn't cached in ProjectsMap.Mar 3 2016, 19:37
dereckson updated this revision to Diff 770.Mar 3 2016, 19:49
dereckson edited edge metadata.

Rebased after D325 merge.

alken-orin added a comment.Mar 3 2016, 19:49

Build started: https://ci.nasqueron.org/job/test-notifications-phab/115/ (console: https://ci.nasqueron.org/job/test-notifications-phab/115/console)

alken-orin added a comment.Mar 3 2016, 20:01

Build is green https://ci.nasqueron.org/job/test-notifications-phab/115/ for more details.

dereckson accepted this revision.Mar 7 2016, 22:42
dereckson edited edge metadata.
This revision is now accepted and ready to land.Mar 7 2016, 22:42
Closed by commit rNOTIFfea5b9c2d83f: Tests for ProjectsMap (authored by dereckson, committed by dereckson). · Explain WhyMar 7 2016, 22:43
This revision was automatically updated to reflect the committed changes.
dereckson mentioned this in D332: Prune unfinished ProjectsMap tests.Mar 8 2016, 01:05
dereckson mentioned this in rNOTIF8758ba52dce4: Prune unfinished ProjectsMap tests.Mar 8 2016, 01:07

Revision Contents
Changeset List

PathSize
tests/
Phabricator/
137 lines

Diff 767

View Options

tests/Phabricator/ProjectsMapTest.php

Loading...
Nasqueron DevCentral · If it had been much bigger the moon would have had a core of ice. · Powered by Phabricator