Paths

Table of Contentst

Don't panic if site path can't be resolved
ClosedPublic
Actions

Authored by dereckson on Apr 13 2023, 01:28.

Tags

None

Referenced Files

	F23676557: D3010.id7685.diff
	Fri, Feb 6, 00:45

	F23666690: D3010.id7683.diff
	Thu, Feb 5, 23:34

	F23666689: D3010.id7684.diff
	Thu, Feb 5, 23:34

	F23662141: D3010.id7683.diff
	Thu, Feb 5, 23:02

	F23662133: D3010.id7685.diff
	Thu, Feb 5, 23:02

	F23636311: D3010.id7685.diff
	Thu, Feb 5, 19:55

	F23635841: D3010.id7683.diff
	Thu, Feb 5, 19:52

	F23635840: D3010.id7684.diff
	Thu, Feb 5, 19:52

View All Files

Subscribers

None

Details

Reviewers

dereckson

Maniphest Tasks

T1830: Panic when a site name can't be resolved

Commits

rALK42ac05d593ec: Don't panic if site path can't be resolved

Summary

Throw an explicit error, with rich metadata to help debug from the web log:

what site?
init or deploy?

CLI can also benefit of this more explicit error message.

Fixes T1830.

Test Plan

HTTP. Fire web server, POST to http://localhost:10206/deploy/foo
CLI. alkane deploy foo

Diff Detail

Repository

rALK Alkane

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

dereckson requested review of this revision.Apr 13 2023, 01:28

dereckson created this revision.

Harbormaster completed remote builds in B4757: Diff 7683.Apr 13 2023, 01:28

Bump version

Harbormaster completed remote builds in B4758: Diff 7684.Apr 13 2023, 01:30

dereckson accepted this revision.Apr 13 2023, 01:31

This revision is now accepted and ready to land.Apr 13 2023, 01:31

Closed by commit rALK42ac05d593ec: Don't panic if site path can't be resolved (authored by dereckson). · Explain WhyApr 13 2023, 01:32

This revision was automatically updated to reflect the committed changes.

dereckson added a commit: rALK42ac05d593ec: Don't panic if site path can't be resolved.

Revision Contents
Changeset List

Path

Size

Cargo.toml

2 lines

src/

actions.rs

43 lines

deploy.rs

20 lines

main.rs

2 lines

server/

requests.rs

6 lines

Diff 7685

View Options

Cargo.toml

View Options

src/actions.rs

View Options

src/deploy.rs

View Options

src/main.rs

View Options

Don't panic if site path can't be resolvedClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 7685

Cargo.toml

src/actions.rs

src/deploy.rs

src/main.rs

src/server/requests.rs

Don't panic if site path can't be resolved
ClosedPublic
Actions

Revision Contents
Changeset List