Paths

Table of Contentst

Log correctly stdout and stderr
ClosedPublic
Actions

Authored by dereckson on Apr 14 2023, 20:56.

Tags

None

Referenced Files

	F19205280: D3014.id7692.diff
	Thu, Dec 25, 10:47

	F19139874: D3014.id.diff
	Wed, Dec 24, 19:45

	Unknown Object (File)
	Wed, Dec 24, 06:42

	Unknown Object (File)
	Tue, Dec 23, 23:19

	Unknown Object (File)
	Tue, Dec 23, 20:22

	Unknown Object (File)
	Sun, Dec 21, 21:26

	Unknown Object (File)
	Tue, Dec 16, 11:33

	Unknown Object (File)
	Thu, Dec 11, 10:09

View All Files

Subscribers

None

Details

Reviewers

dereckson

Commits

rALK9e3423554678: Log correctly stdout and stderr

Summary

Stdio::piped() isn't necessary to capture the output of a process.

Also, a typo in the implementation confused stdout and stderr.

Test Plan

alkane serve, /init and /update
alkane deploy

Diff Detail

Repository

rALK Alkane

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

dereckson requested review of this revision.Apr 14 2023, 20:56

dereckson created this revision.

Harbormaster completed remote builds in B4763: Diff 7692.Apr 14 2023, 20:56

Don't bump version I've seen another issue

Harbormaster completed remote builds in B4764: Diff 7693.Apr 14 2023, 20:56

dereckson accepted this revision.Apr 14 2023, 21:09

This revision is now accepted and ready to land.Apr 14 2023, 21:09

Closed by commit rALK9e3423554678: Log correctly stdout and stderr (authored by dereckson). · Explain WhyApr 14 2023, 21:11

This revision was automatically updated to reflect the committed changes.

dereckson added a commit: rALK9e3423554678: Log correctly stdout and stderr.

Revision Contents
Changeset List

Path

Size

src/

runner/

mod.rs

8 lines

Diff 7694

View Options

Log correctly stdout and stderrClosedPublicActions