PhpFpmEnvironment::getEnvironmentVariables refactoring
ClosedPublic
Actions

Authored by dereckson on Nov 8 2015, 22:58.

Details

Reviewers

Commits

rDPHPVIIFPMdf34942bdc01: PhpFpmEnvironment::getEnvironmentVariables refactoring
rDPHPFPMdf34942bdc01: PhpFpmEnvironment::getEnvironmentVariables refactoring

Summary

Split PhpFpmEnvironment::getEnvironmentVariables in more discrete methods.

New static methods:

addTempEnvironmentVariables: add TMP, TEMP, TMPDIR env variable to an array
addPathEnvironmentVariables: add PATH env variable to an array
addHardcodedEnvironmentVariables: add both to an array

Test Plan

compare output before and after the change

Diff Detail

Repository

rDPHPFPM Docker image for Nginx, php-fpm

Lint

No Lint Coverage

Unit

No Test Coverage

Branch

refactoring

Build Status

Buildable 23
Build 23: arc lint + arc unit

Event Timeline

dereckson updated this revision to Diff 77.Nov 8 2015, 22:58

dereckson retitled this revision from to PhpFpmEnvironment::getEnvironmentVariables refactoring.

dereckson updated this object.

dereckson edited the test plan for this revision. (Show Details)

dereckson added a reviewer: Sandlayth.

Herald added a project: Nasqueron Docker deployment squad. · View Herald TranscriptNov 8 2015, 22:58

Sandlayth accepted this revision.Nov 10 2015, 09:21

Sandlayth edited edge metadata.

This revision is now accepted and ready to land.Nov 10 2015, 09:21

Closed by commit rDPHPFPMdf34942bdc01: PhpFpmEnvironment::getEnvironmentVariables refactoring (authored by dereckson, committed by dereckson). · Explain WhyNov 10 2015, 13:50

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

files/

usr/

local/

lib/

php-fpm-env/

PhpFpmEnvironment.php

38 lines

Diff 77

View Options

files/usr/local/lib/php-fpm-env/PhpFpmEnvironment.php

PhpFpmEnvironment::getEnvironmentVariables refactoringClosedPublicActions