Paths

Table of Contentst

Differential D3724

Allow to remove a word from developer dictionary
ClosedPublic
Actions

Authored by dereckson on Thu, Sep 25, 16:47.

Tags

None

Referenced Files

	F12039490: D3724.diff
	Sun, Sep 28, 09:22

	F12019756: D3724.id9632.diff
	Sun, Sep 28, 02:13

	Unknown Object (File)
	Sat, Sep 27, 20:00

	Unknown Object (File)
	Sat, Sep 27, 19:51

	Unknown Object (File)
	Sat, Sep 27, 18:51

	Unknown Object (File)
	Sat, Sep 27, 17:59

	Unknown Object (File)
	Sat, Sep 27, 17:50

	Unknown Object (File)
	Sat, Sep 27, 16:03

View All 10 Files

Subscribers

None

Details

Reviewers

Maniphest Tasks

T2136: Allow to remove a word from developer dictionary

Commits

rMDb5395730a935: Allow to remove a word from developer dictionary

Summary

Remove words from all known dictionaries, local and Git.

Fixes T2136.

Test Plan

bin/merge-dictionaries --delete alowed

Diff Detail

Repository

rMD Merge dev dictionaries

Lint

Lint Errors

Severity	Location	Code	Message
Error	src/mergedictionaries/actions/__init__.py:9	F401	flake8 F401
Error	src/mergedictionaries/actions/delete_words.py:34	E501	flake8 E501
Error	src/mergedictionaries/actions/delete_words.py:38	E501	flake8 E501
Error	src/mergedictionaries/app/app.py:67	E501	flake8 E501
Error	src/mergedictionaries/app/app.py:120	E501	flake8 E501

Unit

No Test Coverage

Branch

delete

Build Status

Buildable 5972
Build 6254: arc lint + arc unit

Event Timeline

dereckson requested review of this revision.Thu, Sep 25, 16:47

dereckson created this revision.

Harbormaster completed remote builds in B5972: Diff 9632.Thu, Sep 25, 16:47

dereckson accepted this revision.Thu, Sep 25, 16:50

dereckson added inline comments.

src/mergedictionaries/actions/__init__.py
9	False positive: used in bin/ script: `from mergedictionaries.actions import DeleteAction `

This revision is now accepted and ready to land.Thu, Sep 25, 16:50

This revision was landed with ongoing or failed builds.Thu, Sep 25, 17:03

Closed by commit rMDb5395730a935: Allow to remove a word from developer dictionary (authored by dereckson). · Explain Why

This revision was automatically updated to reflect the committed changes.

dereckson added a commit: rMDb5395730a935: Allow to remove a word from developer dictionary.

Revision Contents
Changeset List

Path

Size

34 lines

2 lines

src/

mergedictionaries/

actions/

9 lines

delete_words.py

46 lines

app/

32 lines

utils/

31 lines

write/

19 lines

16 lines

Diff 9632

README.md

Loading...

setup.cfg

Loading...

src/mergedictionaries/actions/init.py

Loading...

src/mergedictionaries/actions/delete_words.py

Loading...

src/mergedictionaries/app/app.py

Loading...

src/mergedictionaries/utils/collections.py

Loading...

src/mergedictionaries/write/git.py

Loading...

src/mergedictionaries/write/jetbrains.py

Loading...