Differential D3830

Accept to load an application without a specific icon defined
ClosedPublic
Actions

Authored by dereckson on Thu, Oct 30, 22:17.

Details

Reviewers

dereckson

Commits

rOBSIDIANc0138cc49992: Accept to load an application without a specific icon defined

Summary

This fixes the following issue:

PHP Fatal error:
Typed property Waystone\Workspaces\Engines\Apps\ApplicationConfiguration::$icon
must not be accessed before initialization
in /var/51-wwwroot/obsidian/workspaces/src/controllers/header.php:61

Diff Detail

Repository

rOBSIDIAN Obsidian Workspaces

Lint

No Lint Coverage

Unit

No Test Coverage

Branch

debug-mediawiki

Build Status

Buildable 6119
Build 6403: arc lint + arc unit

Event Timeline

dereckson requested review of this revision.Thu, Oct 30, 22:17

dereckson created this revision.

Harbormaster completed remote builds in B6119: Diff 9917.Thu, Oct 30, 22:17

dereckson accepted this revision.Thu, Oct 30, 22:17

This revision is now accepted and ready to land.Thu, Oct 30, 22:17

Closed by commit rOBSIDIANc0138cc49992: Accept to load an application without a specific icon defined (authored by dereckson). · Explain WhyThu, Oct 30, 22:17

This revision was automatically updated to reflect the committed changes.

dereckson added a commit: rOBSIDIANc0138cc49992: Accept to load an application without a specific icon defined.

Revision Contents
Changeset List

Path

Size

workspaces/

src/

controllers/

header.php

2 lines

Diff 9917

View Options

workspaces/src/controllers/header.php

Accept to load an application without a specific icon definedClosedPublicActions