Concerns addressed by D220 / rNOTIF46a71ea7b2f3.

Build is green https://ci.nasqueron.org/job/test-notifications-phab/13/ for more details.

This commit introduced dead code, as the class Log is declared but never used.

Build started: https://ci.nasqueron.org/job/test-notifications-phab/13/ (console: https://ci.nasqueron.org/job/test-notifications-phab/13/console)

Test coverage. This change brings full coverage for GateController class.

Build is green https://ci.nasqueron.org/job/test-notifications-phab/12/ for more details.

Build started: https://ci.nasqueron.org/job/test-notifications-phab/12/ (console: https://ci.nasqueron.org/job/test-notifications-phab/12/console)

Build is green https://ci.nasqueron.org/job/test-notifications-phab/11/ for more details.

Code documentation restored.

Build started: https://ci.nasqueron.org/job/test-notifications-phab/11/ (console: https://ci.nasqueron.org/job/test-notifications-phab/11/console)

+1 line covered, +1 method fully covered.

Build is green https://ci.nasqueron.org/job/test-notifications-phab/10/ for more details.

Build started: https://ci.nasqueron.org/job/test-notifications-phab/10/ (console: https://ci.nasqueron.org/job/test-notifications-phab/10/console)

Build is green https://ci.nasqueron.org/job/test-notifications-phab/9/ for more details.

Build started: https://ci.nasqueron.org/job/test-notifications-phab/9/ (console: https://ci.nasqueron.org/job/test-notifications-phab/9/console)

Upstream not interested by the change, but provides a simpler solution.

Build is green https://ci.nasqueron.org/job/test-notifications-phab/8/ for more details.

Build started: https://ci.nasqueron.org/job/test-notifications-phab/8/ (console: https://ci.nasqueron.org/job/test-notifications-phab/8/console)

In D197#3104, @dereckson wrote:

We need to mock the broker.

Code to mock

Broker::setExchangeTarget($this->target)
    ->routeTo($this->routingKey)
    ->sendMessage($this->message);

Mock proposal

$mock = Mockery('Keruald\Broker\AMQPBroker');

$mock->shouldReceive('setExchangeTarget'); // TODO: return $this, not null
$mock->shouldReceive('routeTo');
$mock->shouldReceive('sendMessage');

$this->app->instance('broker', $mock);

Reference: http://docs.mockery.io/en/latest/reference/demeter_chains.html

Build is green https://ci.nasqueron.org/job/test-notifications-phab/7/ for more details.

Build started: https://ci.nasqueron.org/job/test-notifications-phab/7/ (console: https://ci.nasqueron.org/job/test-notifications-phab/7/console)

Build is green https://ci.nasqueron.org/job/test-notifications-phab/6/ for more details.

Build started: https://ci.nasqueron.org/job/test-notifications-phab/6/ (console: https://ci.nasqueron.org/job/test-notifications-phab/6/console)

Build is green https://ci.nasqueron.org/job/test-notifications-phab/5/ for more details.

Build started: https://ci.nasqueron.org/job/test-notifications-phab/5/ (console: https://ci.nasqueron.org/job/test-notifications-phab/5/console)

Added PayloadFullTest::testInvalidSignature to hunt 403

Build is green https://ci.nasqueron.org/job/test-notifications-phab/4/ for more details.

Build started: https://ci.nasqueron.org/job/test-notifications-phab/4/ (console: https://ci.nasqueron.org/job/test-notifications-phab/4/console)

Build has FAILED

Build started: https://ci.nasqueron.org/job/test-notifications-phab/3/ (console: https://ci.nasqueron.org/job/test-notifications-phab/3/console)

Rebased.