Add 404 error page and catch-all route
AbandonedPublic
Actions

Authored by Chenani-MohamedAmine on Tue, Feb 24, 12:16.

Details

Reviewers

Summary

Here is the clean revision for the 404 page. I've stripped out all the unrelated navbar/logo changes and fixed the trailing newline issue as requested in D3971 -(https://devcentral.nasqueron.org/D3971)

Diff Detail

Repository

rSP ServPulse

Lint

Lint Skipped

Unit

No Test Coverage

Branch

feature/404-error-page

Build Status

Buildable 6367
Build 6651: arc lint + arc unit

Event Timeline

Chenani-MohamedAmine requested review of this revision.Tue, Feb 24, 12:16

Chenani-MohamedAmine created this revision.

Harbormaster completed remote builds in B6363: Diff 10312.Tue, Feb 24, 12:16

Chenani-MohamedAmine mentioned this in D3971: NotFound.vue.Tue, Feb 24, 12:39

Chenani-MohamedAmine edited the summary of this revision. (Show Details)Tue, Feb 24, 12:52

Chenani-MohamedAmine updated this revision to Diff 10313.Tue, Feb 24, 15:10

This comment was removed by Chenani-MohamedAmine.

Harbormaster completed remote builds in B6364: Diff 10313.Tue, Feb 24, 15:10

fix

Harbormaster completed remote builds in B6365: Diff 10314.Tue, Feb 24, 15:37

ieli requested changes to this revision.Tue, Feb 24, 21:23

ieli added inline comments.

frontend/src/router/index.js
6–55	The diff shows the entire file was reformatted from 2-space indentation to 4-space indentation. This should be reverted to maintain consistency with the rest of the codebase.
frontend/src/views/NotFound.vue
2–26	The new `NotFound.vue` component doesn't have a corresponding test file. Please add tests at `frontend/src/views/__tests__/NotFound.test.js` following the pattern used in `frontend/src/components/__tests__/`.