Page MenuHomeDevCentral
Differential D997

Analyze The Japan Times
ClosedPublic
Actions

Authored by Thibaut120094 on Jun 16 2017, 21:26.
Tags
None
Referenced Files
F2841735: D997.id2567.diff
Tue, Apr 23, 00:03
F2841464: D997.id2566.diff
Mon, Apr 22, 23:18
F2841074: D997.id2568.diff
Mon, Apr 22, 22:04
Unknown Object (File)
Sun, Apr 21, 10:01
Unknown Object (File)
Sun, Apr 21, 10:00
Unknown Object (File)
Fri, Apr 19, 07:44
Unknown Object (File)
Fri, Apr 19, 06:02
Unknown Object (File)
Fri, Apr 19, 05:27
View All Files
Subscribers
None

Details

Reviewers
dereckson
Commits
rSTGb2d03e1ca957: Analyze The Japan Times
Summary

Analyze The Japan Times

Test Plan

http://www.japantimes.co.jp/news/2014/04/07/national/politics-diplomacy/kyoto-re-elects-yamada-to-top-post/

Diff Detail

Repository
rSTG Source templates generator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

Thibaut120094 created this revision.Jun 16 2017, 21:26
dereckson requested changes to this revision.Jun 17 2017, 23:37

Looks good.

Note pages/index.dat chmod shouldn't change, as there isn't rationale to have an executable there

pages/thejapantimes.php
26

Whitespace issue.

Ident with 4 spaces (we need an automatic check for arc diff by the way for this one, ideally with an autofix offered).

This revision now requires changes to proceed.Jun 17 2017, 23:37
Thibaut120094 updated this revision to Diff 2548.Jul 5 2017, 17:21
Thibaut120094 edited edge metadata.

Fixed whitespace issues and chmod change.

Thibaut120094 marked an inline comment as done.Jul 5 2017, 17:47
Harbormaster completed remote builds in B1556: Diff 2548.Jul 5 2017, 23:15
dereckson added a comment.Jul 5 2017, 23:17

Looks good to me.

dereckson requested changes to this revision.Jul 29 2017, 10:20
dereckson added inline comments.
pages/thejapantimes.php
25

Strict Standards: Only variables should be passed by reference in /usr/home/dereckson/dev/nasqueron/tools/3rdparty/source-templates-generator/pages/thejapantimes.php on line 24

This revision now requires changes to proceed.Jul 29 2017, 10:20
dereckson updated this revision to Diff 2566.Jul 30 2017, 12:50
dereckson edited edge metadata.

Use between for title

dereckson updated this revision to Diff 2567.Jul 30 2017, 12:51

Grammar

dereckson accepted this revision.Jul 30 2017, 12:52
This revision is now accepted and ready to land.Jul 30 2017, 12:52
Closed by commit rSTGb2d03e1ca957: Analyze The Japan Times (authored by Thibaut120094, committed by dereckson). · Explain WhyJul 30 2017, 12:52
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
pages/
1 line
26 lines

Diff 2568

View Options

pages/index.dat

Loading...
View Options

pages/thejapantimes.php

Loading...
Nasqueron DevCentral · If it had been much bigger the moon would have had a core of ice. · Powered by Phabricator