Page MenuHomeDevCentral
Files F4060960

D1066.id2728.diff
No OneTemporary
Actions

D1066.id2728.diff
View Options

diff --git a/app/Actions/ActionError.php b/app/Actions/ActionError.php
--- a/app/Actions/ActionError.php
+++ b/app/Actions/ActionError.php
@@ -21,7 +21,7 @@
/**
* Initializes a new action error report instance from the specified Exception
*
- * @param Exception $ex The exception to build an ActionError instance from
+ * @param \Exception $ex The exception to build an ActionError instance from
*/
public function __construct (\Exception $ex) {
$this->type = class_basename(get_class($ex));
diff --git a/app/Events/ReportEvent.php b/app/Events/ReportEvent.php
--- a/app/Events/ReportEvent.php
+++ b/app/Events/ReportEvent.php
@@ -17,7 +17,7 @@
/**
* Creates a new event instance.
*
- * @param ActionReport $action the action to report
+ * @param Action $action the action to report
*/
public function __construct(Action $action) {
$this->action = $action;
diff --git a/app/Listeners/AMQPEventListener.php b/app/Listeners/AMQPEventListener.php
--- a/app/Listeners/AMQPEventListener.php
+++ b/app/Listeners/AMQPEventListener.php
@@ -28,7 +28,7 @@
/**
* Gets routing key, to allow consumers to select the topic they subscribe to.
*
- * @param NotificationEvent $event
+ * @param Notification The $notification from where the keys must be extracted
*/
protected static function getNotificationRoutingKey (Notification $notification) : string {
$keyParts = [
diff --git a/app/Phabricator/ProjectsMap.php b/app/Phabricator/ProjectsMap.php
--- a/app/Phabricator/ProjectsMap.php
+++ b/app/Phabricator/ProjectsMap.php
@@ -65,7 +65,7 @@
/**
* Gets iterator.
*
- * @return Traversable
+ * @return \Traversable
*/
public function getIterator () {
return new \ArrayIterator($this->map);
@@ -140,7 +140,7 @@
* Gets a new ProjectsMap instance and queries Phabricator API to fill it.
*
* @param string $phabricatorInstanceName The Phabricator instance name
- * @param \Nasqueron\Notifications\Contracts\APIClient $apiClient The Phabricator API client
+ * @param \Nasqueron\Notifications\Contracts\APIClient|null $apiClient The Phabricator API client
* @return ProjectsMap
*/
public static function fetch ($phabricatorInstanceName, ?APIClient $apiClient = null) {

File Metadata

Mime Type
text/plain
Expires
Mon, Jan 27, 09:13 (3 h, 18 m)
Storage Engine
blob
Storage Format
Raw Data
Storage Handle
2380240
Default Alt Text
D1066.id2728.diff (2 KB)

Event Timeline

Nasqueron DevCentral · If it had been much bigger the moon would have had a core of ice. · Powered by Phabricator