Page Menu
Home
DevCentral
Search
Configure Global Search
Log In
Files
F3769102
D2994.id7647.diff
No One
Temporary
Actions
View File
Edit File
Delete File
View Transforms
Subscribe
Mute Notifications
Award Token
Flag For Later
Size
3 KB
Referenced Files
None
Subscribers
None
D2994.id7647.diff
View Options
diff --git a/Cargo.toml b/Cargo.toml
--- a/Cargo.toml
+++ b/Cargo.toml
@@ -1,6 +1,6 @@
[package]
name = "limiting-factor"
-version = "0.7.2"
+version = "0.8.0"
authors = [
"Sébastien Santoro <dereckson@espace-win.org>",
]
@@ -25,7 +25,7 @@
r2d2 = { version = "^0.8.10", optional = true }
rocket = "^0.4.11"
rocket_contrib = { version = "^0.4.11", features = [ "json" ] }
-serde = { version = "^1.0.159", optional = true }
+serde = { version = "^1.0.159", features = [ "derive" ], optional = true }
[features]
default = ["minimal"]
diff --git a/src/api/guards.rs b/src/api/guards.rs
new file mode 100755
--- /dev/null
+++ b/src/api/guards.rs
@@ -0,0 +1,92 @@
+//! # API guards
+//!
+//! This module provides reusable guards to use with Rocket.
+
+use rocket::data::{FromDataSimple, Outcome};
+use rocket::{Data, Request};
+use rocket::http::Status;
+use rocket::Outcome::{Failure, Success};
+use serde::{Deserialize, Serialize};
+
+use std::io::Read;
+
+/// The maximum number of characters to read, to avoid DoS
+const REQUEST_BODY_LIMIT: u64 = 1_000_000;
+
+/// A String representation of the request body. Useful when you need to pass it through as is.
+#[derive(Serialize, Deserialize, PartialOrd, PartialEq, Eq, Ord)]
+pub struct RequestBody {
+ /// The UTF-8 content of the request body
+ pub content: String,
+}
+
+impl RequestBody {
+ pub fn new () -> Self {
+ Self {
+ content: String::new(),
+ }
+ }
+
+ /// Convert the request body into a string
+ pub fn into_string (self) -> String {
+ self.content
+ }
+
+ /// Convert the request body into a string, or None if it's empty
+ pub fn into_optional_string (self) -> Option<String> {
+ if self.content.is_empty() {
+ None
+ } else {
+ Some(self.content)
+ }
+ }
+}
+
+impl FromDataSimple for RequestBody {
+ type Error = String;
+
+ fn from_data(_request: &Request, data: Data) -> Outcome<Self, Self::Error> {
+ let mut content = String::new();
+
+ if let Err(e) = data.open().take(REQUEST_BODY_LIMIT).read_to_string(&mut content) {
+ return Failure((Status::InternalServerError, format!("{:?}", e)));
+ }
+
+ Success(Self { content })
+ }
+}
+
+#[cfg(test)]
+mod tests {
+ use super::*;
+
+ #[test]
+ fn test_request_body_new () {
+ let body = RequestBody::new();
+ assert_eq!(0, body.content.len(), "Content should be empty");
+ }
+
+ #[test]
+ fn test_request_body_into_string () {
+ let body = RequestBody { content: "quux".to_string() };
+ assert_eq!(String::from("quux"), body.into_string());
+ }
+
+ #[test]
+ fn test_request_body_into_string_when_empty () {
+ let body = RequestBody::new();
+ assert_eq!(String::new(), body.into_string(), "Content should be empty");
+ }
+
+ #[test]
+ fn test_request_body_into_optional_string () {
+ let body = RequestBody { content: "quux".to_string() };
+ assert_eq!(Some(String::from("quux")), body.into_optional_string());
+ }
+
+ #[test]
+ fn test_request_body_into_optional_string_when_empty () {
+ let body = RequestBody::new();
+ assert_eq!(None, body.into_optional_string());
+ }
+}
diff --git a/src/api/mod.rs b/src/api/mod.rs
--- a/src/api/mod.rs
+++ b/src/api/mod.rs
@@ -6,4 +6,5 @@
Public submodules offered by this module
- - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - */
+pub mod guards;
pub mod replies;
File Metadata
Details
Attached
Mime Type
text/plain
Expires
Sun, Nov 24, 12:59 (9 h, 45 m)
Storage Engine
blob
Storage Format
Raw Data
Storage Handle
2260195
Default Alt Text
D2994.id7647.diff (3 KB)
Attached To
Mode
D2994: Add RequestBody guard for Rocket
Attached
Detach File
Event Timeline
Log In to Comment