Page Menu
Home
DevCentral
Search
Configure Global Search
Log In
Files
F3769530
D260.diff
No One
Temporary
Actions
View File
Edit File
Delete File
View Transforms
Subscribe
Mute Notifications
Award Token
Flag For Later
Size
621 B
Referenced Files
None
Subscribers
None
D260.diff
View Options
diff --git a/app/Http/Controllers/Gate/GitHubGateController.php b/app/Http/Controllers/Gate/GitHubGateController.php
--- a/app/Http/Controllers/Gate/GitHubGateController.php
+++ b/app/Http/Controllers/Gate/GitHubGateController.php
@@ -127,6 +127,12 @@
return true;
}
+ // If the secret is defined, but signature is missing from the
+ // request, we don't need to perform any other validation.
+ if (empty($this->signature)) {
+ return false;
+ }
+
return XHubSignature::validatePayload(
$secret,
$this->rawRequestContent,
File Metadata
Details
Attached
Mime Type
text/plain
Expires
Sun, Nov 24, 15:24 (4 h, 17 m)
Storage Engine
blob
Storage Format
Raw Data
Storage Handle
2260456
Default Alt Text
D260.diff (621 B)
Attached To
Mode
D260: Reject requests without X-Hub-Signature when needed
Attached
Detach File
Event Timeline
Log In to Comment