Page MenuHomeDevCentral

D260.diff
No OneTemporary

D260.diff

diff --git a/app/Http/Controllers/Gate/GitHubGateController.php b/app/Http/Controllers/Gate/GitHubGateController.php
--- a/app/Http/Controllers/Gate/GitHubGateController.php
+++ b/app/Http/Controllers/Gate/GitHubGateController.php
@@ -127,6 +127,12 @@
return true;
}
+ // If the secret is defined, but signature is missing from the
+ // request, we don't need to perform any other validation.
+ if (empty($this->signature)) {
+ return false;
+ }
+
return XHubSignature::validatePayload(
$secret,
$this->rawRequestContent,

File Metadata

Mime Type
text/plain
Expires
Sun, Nov 24, 15:24 (4 h, 17 m)
Storage Engine
blob
Storage Format
Raw Data
Storage Handle
2260456
Default Alt Text
D260.diff (621 B)

Event Timeline