Page MenuHomeDevCentral

Deploy FANTOIR for Daeghrefn
ClosedPublic

Authored by dereckson on Nov 14 2017, 20:43.
Tags
None
Referenced Files
F2828935: D1205.id3090.diff
Fri, Apr 19, 06:23
F2828750: D1205.id3088.diff
Fri, Apr 19, 05:35
F2828594: D1205.id3087.diff
Fri, Apr 19, 04:51
F2827372: D1205.id3086.diff
Thu, Apr 18, 23:53
Unknown Object (File)
Wed, Apr 17, 23:55
Unknown Object (File)
Wed, Apr 17, 19:23
Unknown Object (File)
Mon, Apr 15, 00:20
Unknown Object (File)
Sun, Apr 14, 23:40
Subscribers
None

Details

Summary

FANTOIR is a database used by Daeghrefn for the .fantoir command.

Ref T1309

Data source:
https://www.data.gouv.fr/en/datasets/fichier-fantoir-des-voies-et-lieux-dits/

Test Plan

Test on Ysul, ensure data directory is populated,
and the streets are well extracted.

Diff Detail

Repository
rOPS Nasqueron Operations
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

First run

Ysul
$ salt-call --local state.apply roles/viperserv/fantoir
local:                                 
----------                             
          ID: /srv/viperserv/data                                                                                                                              
    Function: file.directory           
      Result: True                                                                                                                                             
     Comment: Directory /srv/viperserv/data updated                            
     Started: 20:31:14.658705          
    Duration: 53.675 ms                
     Changes:                          
              ----------               
              /srv/viperserv/data:     
                  New Dir              
----------                             
          ID: /srv/viperserv/data/dist 
    Function: file.directory           
      Result: True                     
     Comment: Directory /srv/viperserv/data/dist updated                       
     Started: 20:31:14.712841          
    Duration: 8.497 ms                 
     Changes:                          
              ----------               
              /srv/viperserv/data/dist:
                  New Dir              
----------                                                                                                                                                     
          ID: /srv/viperserv/data/dist/fantoir.zip                             
    Function: file.managed                                                                                                                                     
      Result: True                     
     Comment: File /srv/viperserv/data/dist/fantoir.zip updated                
     Started: 20:31:14.721797                                                                                                                                  
    Duration: 6530.063 ms              
     Changes:                                                                  
              ----------                                                       
              diff:                    
                  New file             
              mode:
                  0644
----------
          ID: viperserv_fantoir_archive
    Function: archive.extracted        
        Name: /srv/viperserv/data      
      Result: True                     
     Comment: /srv/viperserv/data/dist/fantoir.zip extracted to /srv/viperserv/data/, due to absence of one or more files/dirs                                 
     Started: 20:31:21.257211          
    Duration: 23414.381 ms             
     Changes:                          
              ----------               
              extracted_files:         
                  - FANTOIR1017        
----------                             
          ID: /srv/viperserv/data/FANTOIR.txt                                  
    Function: file.symlink             
      Result: True                     
     Comment: Created new symlink /srv/viperserv/data/FANTOIR.txt -> /srv/viperserv/data/FANTOIR1017                                                           
     Started: 20:31:44.673497          
    Duration: 33.61 ms                 
     Changes:                          
              ----------               
              new:                     
                  /srv/viperserv/data/FANTOIR.txt                              
----------                             
          ID: viperserv_fantoir_streets
    Function: cmd.run                  
        Name: grep -a "^[0-9]" /srv/viperserv/data/FANTOIR.txt > /srv/viperserv/data/FANTOIR_STREETS.txt                                                       
      Result: True                     
     Comment: Command "grep -a "^[0-9]" /srv/viperserv/data/FANTOIR.txt > /srv/viperserv/data/FANTOIR_STREETS.txt" run                                         
     Started: 20:31:44.711547          
    Duration: 9684.872 ms              
     Changes:                          
              ----------               
              pid:                     
                  21345                
              retcode:                 
                  0                    
              stderr:                  
              stdout:                  

Summary for local                      
------------                           
Succeeded: 6 (changed=6)               
Failed:    0                           
------------                           
Total states run:     6                
Total run time:  39.725 s  

Control

Ysul
$ cd /srv/viperserv/data
$ wc *.txt
 7964379 83397597 957122898 FANTOIR_STREETS.txt                                
 7964380 83397600 957122958 FANTOIR.txt                                       
 15928759 166795197 1914245856 total  

It seems the code RIVOLI to check isn't the first character of the file, but the character at the 11th position.

See https://www.data.gouv.fr/s/resources/fichier-fantoir-des-voies-et-lieux-dits/community/20150512-103719/Descriptif_FANTOIR.pdf

Second run

Expected output: no-op

Ysul
$ salt-call --local state.apply roles/viperserv/fantoir
local:
----------
          ID: /srv/viperserv/data
    Function: file.directory
      Result: True
     Comment: Directory /srv/viperserv/data is in the correct state
              Directory /srv/viperserv/data updated
     Started: 20:48:55.940437
    Duration: 35.258 ms
     Changes:   
----------
          ID: /srv/viperserv/data/dist
    Function: file.directory
      Result: True
     Comment: Directory /srv/viperserv/data/dist is in the correct state
              Directory /srv/viperserv/data/dist updated
     Started: 20:48:55.976155
    Duration: 4.984 ms
     Changes:   
----------
          ID: /srv/viperserv/data/dist/fantoir.zip
    Function: file.managed
      Result: True
     Comment: File /srv/viperserv/data/dist/fantoir.zip is in the correct state
     Started: 20:48:55.981592
    Duration: 6574.492 ms
     Changes:   
----------
          ID: viperserv_fantoir_archive
    Function: archive.extracted
        Name: /srv/viperserv/data
      Result: True
     Comment: All files in archive are already present
     Started: 20:49:02.560550
    Duration: 10445.015 ms
     Changes:   
----------
          ID: /srv/viperserv/data/FANTOIR.txt
    Function: file.symlink
      Result: True
     Comment: Symlink /srv/viperserv/data/FANTOIR.txt is present and owned by root:wheel
     Started: 20:49:13.007468
    Duration: 234.98 ms
     Changes:   
----------
          ID: viperserv_fantoir_streets
    Function: cmd.run
        Name: grep -a "^[0-9]" /srv/viperserv/data/FANTOIR.txt > /srv/viperserv/data/FANTOIR_STREETS.txt
      Result: True
     Comment: /srv/viperserv/data/FANTOIR_STREETS.txt exists
     Started: 20:49:13.246960
    Duration: 1.837 ms
     Changes:   

Summary for local
------------
Succeeded: 6
Failed:    0
------------
Total states run:     6
Total run time:  17.297 s

User/group for files operations

Use 109th character to determine if it's or not a 'voie'.

Switch to a Python script to extract

dereckson edited the summary of this revision. (Show Details)
dereckson edited the test plan for this revision. (Show Details)
dereckson added inline comments.
roles/viperserv/fantoir/files/extract_streets.py
31

stderr

dereckson marked an inline comment as done.
$ ls -lah /srv/viperserv/data                                                                             (git)-[fantoir] 
total 604886
drwxrwx---  3 viperserv  nasqueron-irc     6B Nov 14 21:55 .
drwxrwx---  7 viperserv  nasqueron-irc     7B Nov 14 20:31 ..
drwxrwx---  2 viperserv  nasqueron-irc     3B Nov 14 20:31 dist
-rw-r--r--  1 viperserv  nasqueron-irc   197M Nov 14 21:55 FANTOIR_STREETS.txt
lrwxr-xr-x  1 viperserv  nasqueron-irc    31B Nov 14 22:05 FANTOIR.txt -> /srv/viperserv/data/FANTOIR1017
-rw-r--r--  1 viperserv  nasqueron-irc   913M Nov 14 20:31 FANTOIR1017
This revision is now accepted and ready to land.Nov 14 2017, 22:05
This revision was automatically updated to reflect the committed changes.