Differential D1355

Migrate the Salt states and modules to Python 3
ClosedPublic
Actions

Authored by dereckson on Feb 28 2018, 12:57.

Details

Reviewers

dereckson

Maniphest Tasks

T1343: Migrate Salt to Python 3

Commits

rOPSe51a03a6b78b: Migrate the Salt states and modules to Python 3

Summary

Ref T1343.

Test Plan

Run unit tests for modules
Run modified modules functions
Run in test mode modified states

Diff Detail

Repository

rOPS Nasqueron Operations

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

dereckson requested review of this revision.Feb 28 2018, 12:57

dereckson created this revision.

Tests units pass.

This part currently committed works fine.

I've still to check the viperserv role's account unit: in roles/viperserv/account/init.sls and roles/viperserv/account/files/viperserv.sudoers, a string is iterated letter by letter.

Ysul

$ salt-call --local node.filter_by_role web_content_sls
local:
    - .be/dereckson
    - .org/nasqueron/api
    - .org/nasqueron/docs
    - .org/nasqueron/labs

$ salt-call --local state.apply roles/bastion/yubico/authorized_yubikeys test=True
[…]
Succeeded: 2
Failed:    0
[…]

$ salt-call --local forest.get_users
[dictionary with the correct users list]

$ salt-call --local state.apply roles/core/users test=True
[dictionaries are correctly iterated]

$ salt-call --local state.apply roles/devserver/webserver-wwwroot51 test=True
[dictionaries are correctly iterated]
Succeeded: 7
Failed:    0
[…]

$ salt-call --local state.apply roles/viperserv/account test=True
[a string is parsed as an iterable in the the sudoers template]

$ salt-call --local state.apply roles/webserver-legacy/php-sites/account test=True
[dictionaries are correctly iterated]

$ salt-call --local state.apply roles/webserver-legacy/php-sites/files test=True
[dictionaries are correctly iterated]

$ salt-call --local state.apply roles/webserver-legacy/php-sites/php-fpm test=True
[dictionaries are correctly iterated]