Improve support for multiple remote addresses
ClosedPublic
Actions

Authored by dereckson on May 13 2018, 18:48.

Tags

None

Referenced Files

	F23630505: D1638.id4179.diff
	Thu, Feb 5, 19:18

	Unknown Object (File)
	Wed, Feb 4, 13:16

	Unknown Object (File)
	Mon, Feb 2, 07:44

	Unknown Object (File)
	Sun, Feb 1, 17:38

	Unknown Object (File)
	Wed, Jan 28, 05:24

	Unknown Object (File)
	Mon, Jan 26, 10:42

	Unknown Object (File)
	Sat, Jan 24, 15:05

	Unknown Object (File)
	Fri, Jan 16, 16:21

View All Files

Subscribers

None

Details

Reviewers

dereckson

Commits

rKOT0ad391265fdd: Improve support for multiple remote addresses

Summary

Currently, if a proxy declares more than one remote address,
the separator needed to be a comma.

But Squid documentation provides a syntax with spaces.

To provide a better support, this change explodes the IP address
with several delimiters, comma and whitespaces (\r \n \t \f and space).

Test Plan

New tests provided

Diff Detail

Repository

rKOT Keruald OmniTools

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

dereckson requested review of this revision.May 13 2018, 18:48

dereckson created this revision.

Harbormaster completed remote builds in B2568: Diff 4179.May 13 2018, 18:48

dereckson accepted this revision.May 13 2018, 19:22

This revision is now accepted and ready to land.May 13 2018, 19:22

Closed by commit rKOT0ad391265fdd: Improve support for multiple remote addresses (authored by dereckson). · Explain WhyMay 13 2018, 19:22

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

HTTP/

Requests/

RemoteAddress.php

8 lines

tests/

HTTP/

Requests/

RequestTest.php

20 lines

Diff 4181

View Options

src/HTTP/Requests/RemoteAddress.php