Page MenuHomeDevCentral

Craft automatic staging area default commit
ClosedPublic

Authored by dereckson on Oct 27 2018, 20:41.

Details

Summary

Provide a staging-commit-message command to get a default content
for submodule update commits.

Fixes T1470.

Test Plan
$ git commit -a -m "$(staging-commit-message)"

Diff Detail

Repository
rOPS Nasqueron Operations
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

dereckson requested review of this revision.Oct 27 2018, 20:41
dereckson created this revision.
dereckson edited the test plan for this revision. (Show Details)Oct 27 2018, 20:59
dereckson marked 3 inline comments as done.Oct 27 2018, 21:06
dereckson added inline comments.
roles/saltmaster/software/files/staging-commit-message.py
56

Can be a static method

57

shadows the hash function

roles/saltmaster/software/init.sls
24

Okay, in the repo the file is chmoded 755. But Salt copies by default in 644.

dereckson updated this revision to Diff 4947.Oct 27 2018, 21:07

Executable chmod. Improve Python code quality.

dereckson accepted this revision.Oct 27 2018, 21:07
This revision is now accepted and ready to land.Oct 27 2018, 21:07
This revision was automatically updated to reflect the committed changes.