Differential D2125

Detect invalid or missing properties for shellusers
ClosedPublic
Actions

Authored by dereckson on Dec 16 2019, 22:42.

Details

Reviewers

dereckson

Commits

rOPSe90d3fcaec3d: Detect invalid or missing properties for shellusers

Summary

This test has been added to detect a typo in user properties,
like in D2115 "ssh-keys" instead of "ssh_keys".

Test Plan

Tested with D2215 bogus and fixed versions.

Diff Detail

Repository

rOPS Nasqueron Operations

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

dereckson requested review of this revision.Dec 16 2019, 22:42

dereckson created this revision.

Harbormaster completed remote builds in B3309: Diff 5358.Dec 16 2019, 22:42

+\n

Harbormaster completed remote builds in B3310: Diff 5360.Dec 16 2019, 22:45

$ python -m unittest discover pillar/core
F
======================================================================
FAIL: test_users_properties (test_users.Testinstance)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/opt/salt/nasqueron-operations/_tests/pillar/core/test_users.py", line 36, in test_users_properties
    self.assertTrue(is_valid, "\n" + "\n".join(errors))
AssertionError: False is not true :
  Missing properties for alinap: {'ssh_keys'}
  Invalid properties for alinap: {'ssh-keys'}

----------------------------------------------------------------------
Ran 1 test in 0.277s

FAILED (failures=1)

$ python -m unittest discover pillar/core
.
----------------------------------------------------------------------
Ran 1 test in 0.275s