Paths

Table of Contentst

Differential D213

PayloadFullTest with secret verification
ClosedPublic
Actions

Authored by dereckson on Jan 9 2016, 23:55.

Details

Reviewers

dereckson

Commits

Unknown Object (Diffusion Commit)
rNOTIF22216c44b746: PayloadFullTest with secret verification

Summary

To upgrade test coverage, we add a X-Hub-Signature matching the
test credentials.json file added in D212.

Test Plan

phpunit

Diff Detail

Repository

rNOTIF Notifications center

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

dereckson updated this revision to Diff 503.Jan 9 2016, 23:55

dereckson retitled this revision from to PayloadFullTest with secret verification.

dereckson updated this object.

dereckson edited the test plan for this revision. (Show Details)

dereckson added a reviewer: dereckson.

Build started: https://ci.nasqueron.org/job/test-notifications-phab/3/ (console: https://ci.nasqueron.org/job/test-notifications-phab/3/console)

Build has FAILED

Link to build: https://ci.nasqueron.org/job/test-notifications-phab/3/
See console output for more information: https://ci.nasqueron.org/job/test-notifications-phab/3/console

Build started: https://ci.nasqueron.org/job/test-notifications-phab/4/ (console: https://ci.nasqueron.org/job/test-notifications-phab/4/console)

Build is green https://ci.nasqueron.org/job/test-notifications-phab/4/ for more details.

Added PayloadFullTest::testInvalidSignature to hunt 403

Build started: https://ci.nasqueron.org/job/test-notifications-phab/5/ (console: https://ci.nasqueron.org/job/test-notifications-phab/5/console)

Build is green https://ci.nasqueron.org/job/test-notifications-phab/5/ for more details.

dereckson accepted this revision.Jan 10 2016, 01:47

dereckson edited edge metadata.

This revision is now accepted and ready to land.Jan 10 2016, 01:47

Closed by commit rNOTIF22216c44b746: PayloadFullTest with secret verification (authored by dereckson, committed by dereckson). · Explain WhyJan 10 2016, 01:48

This revision was automatically updated to reflect the committed changes.

dereckson mentioned this in D214: Prune never executed code.Jan 10 2016, 01:50

dereckson mentioned this in rNOTIFbe0c324ed737: Prune never executed code.Jan 10 2016, 02:07

Revision Contents
Changeset List

Path

Size

tests/

Http/

Controllers/

GitHubGateControllerTest.php

2 lines

PayloadFullTest.php

29 lines

Diff 505

View Options

tests/Http/Controllers/GitHubGateControllerTest.php