Differential D2132

Use sudo to build php-ast
ClosedPublic
Actions

Authored by dereckson on Jan 18 2020, 04:30.

Details

Reviewers

dereckson

Maniphest Tasks

T1557: Can't build php-ast on FreeBSD

Commits

rOPSaa61e4bfdcf6: Use sudo to build php-ast

Summary

When switching user with Salt, Perl can't run some privileges escalation
function like setgid. The same scripts work well through sudo.

This change fixes the following issue:

Insecure $ENV{PATH} while running setgid at /usr/local/bin/autom4te-2.69 line 92.
/opt/php-ast/__salt.tmp.0tbvmu8_.sh: ./configure: not found
make: no target to make.

Fixes T1557.

Test Plan

Tested on WindRiver

Diff Detail

Repository

rOPS Nasqueron Operations

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

dereckson requested review of this revision.Jan 18 2020, 04:30

dereckson created this revision.

Harbormaster completed remote builds in B3319: Diff 5375.Jan 18 2020, 04:30

dereckson accepted this revision.Jan 18 2020, 04:30

This revision is now accepted and ready to land.Jan 18 2020, 04:30

This revision was landed with ongoing or failed builds.Jan 18 2020, 04:31

Closed by commit rOPSaa61e4bfdcf6: Use sudo to build php-ast (authored by dereckson). · Explain Why

This revision was automatically updated to reflect the committed changes.

dereckson added a commit: rOPSaa61e4bfdcf6: Use sudo to build php-ast.

Revision Contents
Changeset List

Path

Size

roles/

devserver/

userland-software/

files/

install-php-extension.sh

8 lines

php-ast.sls

1 line

Diff 5376

View Options

roles/devserver/userland-software/files/install-php-extension.sh