Differential D2267

Drop empty value for php-fpm environment variable
ClosedPublic
Actions

Authored by dereckson on Feb 27 2020, 12:18.

Tags

None

Referenced Files

	Unknown Object (File)
	Tue, Nov 12, 16:03

	Unknown Object (File)
	Sat, Nov 9, 07:55

	Unknown Object (File)
	Tue, Nov 5, 06:48

	Unknown Object (File)
	Tue, Nov 5, 05:27

	Unknown Object (File)
	Mon, Nov 4, 09:53

	Unknown Object (File)
	Sun, Nov 3, 16:10

	Unknown Object (File)
	Thu, Oct 31, 09:58

	Unknown Object (File)
	Sat, Oct 26, 06:55

Subscribers

None

Details

Reviewers

Maniphest Tasks

T1598: Rebuild cachet container

Commits

rOPSd4f0ec8e6a4a: Drop empty value for php-fpm environment variable

Summary

php-fpm doesn't accept empty values as environment variables.

It somewhat makes sense, as "" is actually the value
for an undefined environment variable.

Fixes the following issue:

[27-Feb-2020 12:00:23] ERROR: [/usr/local/etc/php-fpm-env.conf:9] empty value
[27-Feb-2020 12:00:23] ERROR: Unable to include /usr/local/etc/php-fpm-env.conf from /usr/local/etc/php-fpm.conf at line 9
[27-Feb-2020 12:00:23] ERROR: failed to load configuration file '/usr/local/etc/php-fpm.conf'
[27-Feb-2020 12:00:23] ERROR: FPM initialization failed

Ref T1598.

Test Plan

Run container and ensure php-fpm initializes

Diff Detail

Repository

rOPS Nasqueron Operations

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

dereckson requested review of this revision.Feb 27 2020, 12:18

dereckson created this revision.

Harbormaster completed remote builds in B3507: Diff 5695.Feb 27 2020, 12:18

dereckson edited the test plan for this revision. (Show Details)Feb 27 2020, 12:18

dereckson accepted this revision.Feb 27 2020, 14:25

This revision is now accepted and ready to land.Feb 27 2020, 14:25

Closed by commit rOPSd4f0ec8e6a4a: Drop empty value for php-fpm environment variable (authored by dereckson). · Explain WhyFeb 27 2020, 14:25

This revision was automatically updated to reflect the committed changes.

dereckson added a commit: rOPSd4f0ec8e6a4a: Drop empty value for php-fpm environment variable.

Revision Contents
Changeset List

Path

Size

roles/

paas-docker/

containers/

1 line

Diff 5696

roles/paas-docker/containers/cachet.sls

Loading...