Page MenuHomeDevCentral

Define commands as a dictionary instead of a tuple
ClosedPublic

Authored by dereckson on Sep 4 2021, 20:15.
Tags
None
Referenced Files
F2745114: D2406.diff
Thu, Mar 28, 21:35
Unknown Object (File)
Thu, Mar 21, 02:15
Unknown Object (File)
Mon, Mar 18, 02:57
Unknown Object (File)
Mon, Mar 18, 02:57
Unknown Object (File)
Mon, Mar 18, 02:56
Unknown Object (File)
Mon, Mar 18, 01:03
Unknown Object (File)
Mon, Mar 18, 01:03
Unknown Object (File)
Mon, Mar 18, 00:30
Subscribers
None

Details

Reviewers
dereckson
Maniphest Tasks
Unknown Object (Maniphest Task)
Commits
rOPS4509fe3de0a0: Define commands as a dictionary instead of a tuple
Summary

The extraneous comma made commands parsed as a tuple,
not as intended as a dictionary.

This caused any issue to fail the following test:
<command> in commands, as the tuple doesn't have named keys.

Ref T1647.

Test Plan

bats scripts/bats/test_edit_acme_dns_accounts.sh

Diff Detail

Repository
rOPS Nasqueron Operations
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

dereckson created this revision.
This revision is now accepted and ready to land.Sep 4 2021, 20:15
This revision was landed with ongoing or failed builds.Sep 4 2021, 20:15
This revision was automatically updated to reflect the committed changes.