Page MenuHomeDevCentral

Define commands as a dictionary instead of a tuple
ClosedPublic

Authored by dereckson on Sep 4 2021, 20:15.
Tags
None
Referenced Files
F11660984: D2406.diff
Sun, Sep 7, 05:47
Unknown Object (File)
Thu, Aug 28, 00:48
Unknown Object (File)
Mon, Aug 25, 02:42
Unknown Object (File)
Sun, Aug 24, 13:16
Unknown Object (File)
Tue, Aug 19, 14:52
Unknown Object (File)
Mon, Aug 18, 15:29
Unknown Object (File)
Sun, Aug 17, 07:29
Unknown Object (File)
Sun, Aug 17, 07:29
Subscribers
None

Details

Reviewers
dereckson
Maniphest Tasks
Unknown Object (Maniphest Task)
Commits
rOPS4509fe3de0a0: Define commands as a dictionary instead of a tuple
Summary

The extraneous comma made commands parsed as a tuple,
not as intended as a dictionary.

This caused any issue to fail the following test:
<command> in commands, as the tuple doesn't have named keys.

Ref T1647.

Test Plan

bats scripts/bats/test_edit_acme_dns_accounts.sh

Diff Detail

Repository
rOPS Nasqueron Operations
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

dereckson created this revision.
This revision is now accepted and ready to land.Sep 4 2021, 20:15
This revision was landed with ongoing or failed builds.Sep 4 2021, 20:15
This revision was automatically updated to reflect the committed changes.