Differential D2491

Allow to create empty OmniArray
ClosedPublic
Actions

Authored by dereckson on Jan 26 2022, 20:49.

Details

Reviewers

dereckson

Commits

rKOTad3007455fc4: Allow to create empty OmniArray

Summary

This fixes the following issue:

ArgumentCountError : Too few arguments to function
Keruald\OmniTools\Collections\OmniArray::__construct(), 0 passed in
.../keruald/omnitools/src/Strings/Multibyte/OmniString.php on line 98
and exactly 1 expected

Test Plan

New test for OmniString::explode, which does trigger this code path.

Diff Detail

Repository

rKOT Keruald OmniTools

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

dereckson requested review of this revision.Jan 26 2022, 20:49

dereckson created this revision.

Harbormaster completed remote builds in B3880: Diff 6276.Jan 26 2022, 20:49

Move test plan to actual unit test

Harbormaster completed remote builds in B3881: Diff 6277.Jan 26 2022, 20:53

dereckson edited the summary of this revision. (Show Details)Jan 26 2022, 20:55

dereckson edited the test plan for this revision. (Show Details)

Class case in test

Harbormaster completed remote builds in B3882: Diff 6278.Jan 26 2022, 20:56

dereckson accepted this revision.Jan 26 2022, 20:56

This revision is now accepted and ready to land.Jan 26 2022, 20:56

dereckson edited the summary of this revision. (Show Details)Jan 26 2022, 20:57

dereckson edited the summary of this revision. (Show Details)

Closed by commit rKOTad3007455fc4: Allow to create empty OmniArray (authored by dereckson). · Explain WhyJan 26 2022, 20:58

This revision was automatically updated to reflect the committed changes.

dereckson added a commit: rKOTad3007455fc4: Allow to create empty OmniArray.

Revision Contents
Changeset List

Path

Size

src/

Collections/

OmniArray.php

2 lines

tests/

Strings/

Multibyte/

OmniStringTest.php

7 lines

Diff 6279

View Options

src/Collections/OmniArray.php