Differential D2577

Don't shadow variables
ClosedPublic
Actions

Authored by dereckson on Mar 7 2022, 20:14.

Details

Reviewers

dereckson

Commits

rOPS5a1d179f76e5: Don't shadow variables

Summary

Variables like id and list are built-ins.

A method argument can't share the same name with the procedural code.

Diff Detail

Repository

rOPS Nasqueron Operations

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

dereckson requested review of this revision.Mar 7 2022, 20:14

dereckson created this revision.

Harbormaster completed remote builds in B4038: Diff 6510.Mar 7 2022, 20:14

dereckson accepted this revision.Mar 7 2022, 20:16

This revision is now accepted and ready to land.Mar 7 2022, 20:16

This revision was landed with ongoing or failed builds.Mar 7 2022, 20:16

Closed by commit rOPS5a1d179f76e5: Don't shadow variables (authored by dereckson). · Explain Why

This revision was automatically updated to reflect the committed changes.

dereckson added a commit: rOPS5a1d179f76e5: Don't shadow variables.

Revision Contents
Changeset List

Path

Size

_modules/

jails.py

4 lines

opensearch.py

44 lines

zr.py

6 lines

roles/

paas-jails/

jails/

init.sls

2 lines

utils/

dump-py-state.py

4 lines

generate-webcontent-index.py

8 lines

next-uid.py

4 lines

Diff 6511

View Options

_modules/jails.py

View Options

_modules/opensearch.py

View Options

_modules/zr.py

View Options

roles/paas-jails/jails/init.sls

View Options

utils/dump-py-state.py

View Options

utils/generate-webcontent-index.py

View Options

Don't shadow variablesClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 6511

_modules/jails.py

_modules/opensearch.py

_modules/zr.py

roles/paas-jails/jails/init.sls

utils/dump-py-state.py

utils/generate-webcontent-index.py

utils/next-uid.py

Don't shadow variables
ClosedPublic
Actions

Revision Contents
Changeset List