Differential D261

GitHubPayloadAnalyzer exception when payload isn't an object
ClosedPublic
Actions

Authored by dereckson on Jan 24 2016, 08:23.

Details

Reviewers

dereckson

Maniphest Tasks

T695: Send a non JSON error to /gate/GitHub should fail sooner

Commits

Unknown Object (Diffusion Commit)
rNOTIF7f5f73b94803: GitHubPayloadAnalyzer exception when payload isn't an object

Summary

GitHubPayloadAnalyzer constructor requires a $payload parameter,
which is the deserialization of the JSON GitHub payload.

The constructor now checks it's indeed an object, or throws an
exception if not.

Test Plan

Fire a Phabricator payload to /gate/GitHub/projectWithoutSecret

Diff Detail

Repository

rNOTIF Notifications center

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

dereckson updated this revision to Diff 609.Jan 24 2016, 08:23

dereckson added a task: T695: Send a non JSON error to /gate/GitHub should fail sooner.

dereckson retitled this revision from to GitHubPayloadAnalyzer exception when payload isn't an object.

dereckson updated this object.

dereckson edited the test plan for this revision. (Show Details)

dereckson added a reviewer: dereckson.

Build started: https://ci.nasqueron.org/job/test-notifications-phab/52/ (console: https://ci.nasqueron.org/job/test-notifications-phab/52/console)

dereckson accepted this revision.Jan 24 2016, 08:23

dereckson edited the test plan for this revision. (Show Details)

dereckson edited edge metadata.

This revision is now accepted and ready to land.Jan 24 2016, 08:24

Closed by commit rNOTIF7f5f73b94803: GitHubPayloadAnalyzer exception when payload isn't an object (authored by dereckson, committed by dereckson). · Explain WhyJan 24 2016, 08:24

This revision was automatically updated to reflect the committed changes.

Build is green https://ci.nasqueron.org/job/test-notifications-phab/52/ for more details.

Revision Contents
Changeset List

Path

Size

app/

Analyzers/

GitHub/

GitHubPayloadAnalyzer.php

4 lines

Diff 610

View Options

app/Analyzers/GitHub/GitHubPayloadAnalyzer.php

GitHubPayloadAnalyzer exception when payload isn't an objectClosedPublicActions