Differential D262

More thorough validation for GitHub payloads
ClosedPublic
Actions

Authored by dereckson on Jan 24 2016, 08:38.

Details

Reviewers

dereckson

Maniphest Tasks

T695: Send a non JSON error to /gate/GitHub should fail sooner

Commits

Unknown Object (Diffusion Commit)
rNOTIF920690128405: More thorough validation for GitHub payloads

Summary

Any GitHub payload must have:

a X-Github-Event header
a X-Github-Delivery header
a payload, JSON deserializable as an object

A 400 Bad request error is sent if this is not the case.

Test Plan

Send a Phabricator request to /gate/GitHub/ProjectWithoutSecret

Diff Detail

Repository

rNOTIF Notifications center

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

dereckson updated this revision to Diff 611.Jan 24 2016, 08:38

dereckson added a task: T695: Send a non JSON error to /gate/GitHub should fail sooner.

dereckson retitled this revision from to More thorough validation for GitHub payloads.

dereckson updated this object.

dereckson edited the test plan for this revision. (Show Details)

dereckson added a reviewer: dereckson.

Build started: https://ci.nasqueron.org/job/test-notifications-phab/53/ (console: https://ci.nasqueron.org/job/test-notifications-phab/53/console)

dereckson accepted this revision.Jan 24 2016, 08:39

dereckson edited edge metadata.

This revision is now accepted and ready to land.Jan 24 2016, 08:39

Closed by commit rNOTIF920690128405: More thorough validation for GitHub payloads (authored by dereckson, committed by dereckson). · Explain WhyJan 24 2016, 08:39

This revision was automatically updated to reflect the committed changes.

Build is green https://ci.nasqueron.org/job/test-notifications-phab/53/ for more details.

Revision Contents
Changeset List

Path

Size

app/

Http/

Controllers/

Gate/

GitHubGateController.php

23 lines

tests/

Http/

Controllers/

GitHubGateControllerTest.php

13 lines

Diff 612

View Options

app/Http/Controllers/Gate/GitHubGateController.php