Page MenuHomeDevCentral

Detect default branch change in repository GitHub event
AcceptedPublic

Authored by dereckson on Sun, Apr 24, 11:25.

Details

Summary

The repository GitHub event has now in the API a new action "edited",
for example when the repository default branch is changed.

This change assigns to a default branch change payload a new event
"default_branch" overriding the GitHub "repository" one, to avoid
raising too much the complexity of RepositoryEvent.

Fixes T1729.

Test Plan

Unit test provided.

Diff Detail

Repository
rNOTIF Notifications center
Lint
Lint Passed
Unit
Test Failures
Branch
github-default-branch-change
Build Status
Buildable 4213
Build 4465: arc lint + arc unit

Unit TestsBroken

TimeTest
0 ms/usr/home/dereckson/dev/nasqueron/notifications/notifications/tests/Analyzers/GitHub/GitHubPayloadAnalyzerTest.php
Fatal error: Declaration of Nasqueron\Notifications\Tests\Analyzers\GitHubPayloadAnalyzerTest::setUp() must be compatible with Illuminate\Foundation\Testing\TestCase::setUp(): void in /usr/home/dereckson/dev/nasqueron/notifications/notifications/tests/Analyzers/GitHub/GitHubPayloadAnalyzerTest.php on line 33
44 msNasqueron\Notifications\Tests\Analyzers\GitHub\Events\DefaultBranchEventTest

Event Timeline

dereckson created this revision.
This revision is now accepted and ready to land.Sun, May 8, 16:37