Detect default branch change in repository GitHub event
AcceptedPublic
Actions

Authored by dereckson on Sun, Apr 24, 11:25.

Details

Reviewers

Maniphest Tasks

T1729: Handle change default branch GitHub action

Summary

The repository GitHub event has now in the API a new action "edited",
for example when the repository default branch is changed.

This change assigns to a default branch change payload a new event
"default_branch" overriding the GitHub "repository" one, to avoid
raising too much the complexity of RepositoryEvent.

Fixes T1729.

Test Plan

Unit test provided.

Diff Detail

Repository

rNOTIF Notifications center

Lint

Lint Passed

Unit

Test Failures

Branch

github-default-branch-change

Build Status

Buildable 4213
Build 4465: arc lint + arc unit

Unit TestsBroken
View All

	Time	Test
	0 ms	/usr/home/dereckson/dev/nasqueron/notifications/notifications/tests/Analyzers/GitHub/GitHubPayloadAnalyzerTest.php Fatal error: Declaration of Nasqueron\Notifications\Tests\Analyzers\GitHubPayloadAnalyzerTest::setUp() must be compatible with Illuminate\Foundation\Testing\TestCase::setUp(): void in /usr/home/dereckson/dev/nasqueron/notifications/notifications/tests/Analyzers/GitHub/GitHubPayloadAnalyzerTest.php on line 33
	44 ms	Nasqueron\Notifications\Tests\Analyzers\GitHub\Events\DefaultBranchEventTest