Page MenuHomeDevCentral

WIP: identities
Changes PlannedPublic

Authored by dereckson on Jul 14 2015, 00:04.
Tags
None
Referenced Files
F2827658: D27.id1098.diff
Fri, Apr 19, 00:57
F2827604: D27.id1100.diff
Fri, Apr 19, 00:42
F2827488: D27.id1016.diff
Fri, Apr 19, 00:16
F2827374: D27.id1018.diff
Thu, Apr 18, 23:55
Unknown Object (File)
Thu, Apr 18, 03:51
Unknown Object (File)
Thu, Apr 18, 01:37
Unknown Object (File)
Thu, Apr 18, 01:25
Unknown Object (File)
Wed, Apr 17, 10:40
Subscribers

Details

Reviewers
None
Maniphest Tasks
T476: Implement subaccounts
Summary

This is a preview of the identities support.

This will allow to link several identities to an user account,
and to switch from one to another.

Fixes T476.

Diff Detail

Repository
rGROVE Auth Grove
Lint
Lint Passed
Unit
Tests Passed
Branch
identities
Build Status
Buildable 635
Build 754: arc lint + arc unit

Event Timeline

dereckson retitled this revision from to WIP: identities.
dereckson updated this object.
dereckson edited the test plan for this revision. (Show Details)
dereckson added a reviewer: Sandlayth.
dereckson added a subscriber: Sandlayth.

@Sandlayth is interested to test this feature, but not comfortable with the idea to have to review PHP code.

composer.json
11–12

My rebase mrege was wrong: that should be ~0.4 (see 18efcf9)

dereckson marked an inline comment as done.

Caret operator for version in composer.json

dereckson added inline comments.
app/Identity.php
7 ↗(On Diff #1017)

4 spaces?

dereckson marked an inline comment as done.

tabs → spaces

dereckson added inline comments.
app/Models/User.php
151

According getCurrentIdentity:

// Tries to autoselect identity if there is only one
// or if one is configured to be used by default.

Only the first case is here implemented, not the default one.

composer.json
11

Can probably be switched to rKOT?

database/factories/ModelFactory.php
26

use Keruald\OmniTools\Identifiers\UUID;

'uuid' => UUID::UUIDv4();

Or we can also use the new Random::generateIdentifier() to provide 20 bytes instead of 16, but a more compact string ?

database/migrations/2015_07_12_000000_create_identities_table.php
16

Can't this be the primary key?