Differential D273

GitHub push notification message for rebase
ClosedPublic
Actions

Authored by dereckson on Feb 5 2016, 04:09.

Details

Reviewers

dereckson

Maniphest Tasks

T703: GitHub push notification message for rebase

Commits

rNOTIFdb0ec263f8cc: GitHub push notification message for rebase

Summary

When a branch is rebased, then pushed with -f option to GitHub,
a push payload is fired with an empty commits array.

We provide a message to handle this case.

URL comparison is used and welcome, so we keep it.

Fixes T703.

Test Plan

Run tests

Diff Detail

Repository

rNOTIF Notifications center

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

dereckson updated this revision to Diff 633.Feb 5 2016, 04:09

dereckson added a task: T703: GitHub push notification message for rebase.

dereckson retitled this revision from to GitHub push notification message for rebase.

dereckson updated this object.

dereckson edited the test plan for this revision. (Show Details)

dereckson added a reviewer: dereckson.

dereckson accepted this revision.Feb 5 2016, 04:10

dereckson edited edge metadata.

This revision is now accepted and ready to land.Feb 5 2016, 04:10

Closed by commit rNOTIFdb0ec263f8cc: GitHub push notification message for rebase (authored by dereckson, committed by dereckson). · Explain WhyFeb 5 2016, 04:10

This revision was automatically updated to reflect the committed changes.

Build started: https://ci.nasqueron.org/job/test-notifications-phab/56/ (console: https://ci.nasqueron.org/job/test-notifications-phab/56/console)

Build is green https://ci.nasqueron.org/job/test-notifications-phab/56/ for more details.

Revision Contents
Changeset List

Path

Size

app/

Analyzers/

GitHub/

GitHubPayloadAnalyzer.php

5 lines

Diff 634

View Options

app/Analyzers/GitHub/GitHubPayloadAnalyzer.php

GitHub push notification message for rebaseClosedPublicActions