Handle .geoipupdate lock file
ClosedPublic
Actions

Authored by dereckson on Mar 16 2023, 19:14.

Tags

None

Referenced Files

	Unknown Object (File)
	Thu, Apr 30, 21:21

	Unknown Object (File)
	Tue, Apr 28, 14:43

	Unknown Object (File)
	Mon, Apr 27, 09:05

	Unknown Object (File)
	Sun, Apr 26, 09:05

	Unknown Object (File)
	Sat, Apr 25, 19:06

	Unknown Object (File)
	Sat, Apr 25, 09:11

	Unknown Object (File)
	Fri, Apr 24, 08:54

	Unknown Object (File)
	Thu, Apr 23, 09:06

View All Files

Subscribers

None

Details

Reviewers

dereckson

Commits

rOPS8a59aa7594c2: Handle .geoipupdate lock file

Summary

The geoipupdate client creates a lockfile to avoid race conditions.

Drawbacks of the current method is:

no lock file created at first run
can be confusing to see it afterwards

To address both those concerns, the wrapper creates and deletes
this lock file before and after the container run.

Reference: https://github.com/maxmind/geoipupdate-legacy/issues/79

Test Plan

Tested on docker-002

Diff Detail

Repository

rOPS Nasqueron Operations

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

dereckson created this revision.Mar 16 2023, 19:14

Harbormaster completed remote builds in B4578: Diff 7396.Mar 16 2023, 19:14

dereckson requested review of this revision.Mar 16 2023, 19:14

dereckson accepted this revision.Mar 16 2023, 19:15

This revision is now accepted and ready to land.Mar 16 2023, 19:15

Closed by commit rOPS8a59aa7594c2: Handle .geoipupdate lock file (authored by dereckson). · Explain WhyMar 16 2023, 19:15

This revision was automatically updated to reflect the committed changes.

dereckson added a commit: rOPS8a59aa7594c2: Handle .geoipupdate lock file.

Revision Contents
Changeset List

Path

Size

roles/

paas-docker/

wrappers/

files/

geoipupdate.sh

4 lines

Diff 7397

View Options

roles/paas-docker/wrappers/files/geoipupdate.sh

Handle .geoipupdate lock fileClosedPublicActions