Page MenuHomeDevCentral

Update mockito to latest version
ClosedPublic

Authored by EshaanAgg on Sep 10 2023, 18:21.
Tags
None
Referenced Files
F9547435: D3244.id8336.diff
Fri, Jun 6, 22:29
F9547355: D3244.id8334.diff
Fri, Jun 6, 22:28
F9539352: D3244.id8336.diff
Fri, Jun 6, 18:31
F9539345: D3244.id8337.diff
Fri, Jun 6, 18:31
Unknown Object (File)
Fri, Jun 6, 03:41
Unknown Object (File)
Thu, Jun 5, 18:12
Unknown Object (File)
Wed, Jun 4, 19:33
Unknown Object (File)
Wed, Jun 4, 15:14
Subscribers
None

Diff Detail

Repository
rDS Nasqueron Datasources
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

EshaanAgg created this revision.
opendatasoft-explore-api/Cargo.toml
26–27

Perhaps we can now remove this line.

opendatasoft-explore-api/tests/requests_test.rs
58

If we use the full variable name we'll avoid a question "what's that s lost at the end of the method?"

Thanks for the upgrade. Will have a look.

We can also prepare a CI job on Jenkins now we've tests to run.

EshaanAgg marked 2 inline comments as done.
  • upd: Incorporate changes mentioned in review

@dereckson Added the suggested changes. We can work on adding a Jenkin's pipeline in a new issue to keep the issues isolated and to the point. Does that work?

All tests pass successfully o/

dereckson retitled this revision from chore: Update mockito to latest version to Update mockito to latest version.
This revision is now accepted and ready to land.Sep 21 2023, 16:10
This revision was automatically updated to reflect the committed changes.