Page MenuHomeDevCentral
Differential D3536

Stop using deprecated cgi module
ClosedPublic
Actions

Authored by dereckson on Fri, Oct 18, 20:55.
Tags
None
Referenced Files
Unknown Object (File)
Sun, Oct 20, 18:50
Unknown Object (File)
Sun, Oct 20, 18:50
Unknown Object (File)
Sun, Oct 20, 18:50
Unknown Object (File)
Sun, Oct 20, 18:50
Unknown Object (File)
Sun, Oct 20, 18:11
Unknown Object (File)
Sun, Oct 20, 18:11
Unknown Object (File)
Sun, Oct 20, 17:05
Unknown Object (File)
Sun, Oct 20, 17:05
Subscribers
None

Details

Reviewers
dereckson
Maniphest Tasks
T2041: Python 3.13 will remove cgi library used by woof
Commits
rWURF4ceba4deb470: Stop using deprecated cgi module
Summary

The cgi module has been deprecated and will be removed in Python 3.13.

Side edits:

  • adhere more to Python conventions
  • improve HTML doctype
  • proofread messages

Original author: CoolCat467
Source: https://github.com/simon-budig/woof/pull/21

Fixes T2041.

Test Plan
  • woof CONTRIBUTORS.md
  • woof archiv/
  • woof -U (without upload)
  • woof -U, then compare file hashes

Diff Detail

Repository
rWURF wurf
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

dereckson requested review of this revision.Fri, Oct 18, 20:55
dereckson created this revision.
Harbormaster completed remote builds in B5615: Diff 9084.Fri, Oct 18, 20:55
dereckson edited the summary of this revision. (Show Details)Fri, Oct 18, 20:57
dereckson added a task: T2041: Python 3.13 will remove cgi library used by woof.

Please note I'm NOT the author of that code change, this change is from https://github.com/CoolCat467

dereckson accepted this revision.Fri, Oct 18, 21:04
dereckson added inline comments.
woof
146

That's a good question how to detect if the upload has been interrupted.

Normally, that happens with a server when there is a timeout issue, so at this stage of the code I'm not sure it could be reached.

This revision is now accepted and ready to land.Fri, Oct 18, 21:04
Closed by commit rWURF4ceba4deb470: Stop using deprecated cgi module (authored by CoolCat467 <52022020+CoolCat467@users.noreply.github.com>, committed by dereckson). · Explain WhyFri, Oct 18, 21:06
This revision was automatically updated to reflect the committed changes.
dereckson added a commit: rWURF4ceba4deb470: Stop using deprecated cgi module.

Revision Contents
Changeset List

PathSize
121 lines

Diff 9085

View Options

woof

Loading...
Nasqueron DevCentral · If it had been much bigger the moon would have had a core of ice. · Powered by Phabricator