Page MenuHomeDevCentral
Differential D3589

Redirection into the gulfpipe test into /components/gulfpipe.js
Needs RevisionPublic
Actions

Authored by MoustaphaAs on Thu, Nov 14, 11:14.
Tags
None
Referenced Files
Unknown Object (File)
Fri, Nov 15, 23:52
Unknown Object (File)
Fri, Nov 15, 23:24
Unknown Object (File)
Fri, Nov 15, 19:50
Unknown Object (File)
Fri, Nov 15, 19:06
Unknown Object (File)
Fri, Nov 15, 11:47
Unknown Object (File)
Fri, Nov 15, 09:03
Unknown Object (File)
Fri, Nov 15, 04:53
Subscribers
None

Details

Reviewers
dereckson
DorianWinty

Diff Detail

Repository
rUPSECTION Upsection
Lint
Lint Passed
Unit
No Test Coverage
Branch
maketest
Build Status
Buildable 5704
Build 5986: arc lint + arc unit

Event Timeline

MoustaphaAs requested review of this revision.Thu, Nov 14, 11:14
MoustaphaAs created this revision.
Harbormaster completed remote builds in B5704: Diff 9251.Thu, Nov 14, 11:14
MoustaphaAs added a reviewer: dereckson.Thu, Nov 14, 12:04
DorianWinty accepted this revision.Thu, Nov 14, 18:36
This revision is now accepted and ready to land.Thu, Nov 14, 18:36
dereckson requested changes to this revision.Sat, Nov 16, 23:33

In production, if we are in /home/luser/dev/nasqueron/foo, gulpfile.babel.js would be copied from /home/luser/dev/components/gulpfile.js.

So ../../components is only a valid path for the test site, not for production.

We can do the same thing than for UPSECTION variable:

  • define it at the production value by default
  • use ?= to allow override
  • override in make test
This revision now requires changes to proceed.Sat, Nov 16, 23:33

Revision Contents
Changeset List

PathSize
template/
2 lines

Diff 9251

View Options

template/Makefile

Loading...
Nasqueron DevCentral · If it had been much bigger the moon would have had a core of ice. · Powered by Phabricator