Page MenuHomeDevCentral

Provision devcentral local configuration
Needs RevisionPublic

Authored by DorianWinty on Thu, Jan 2, 20:49.
Tags
None
Referenced Files
F3969698: D3623.diff
Sun, Jan 5, 03:41
F3969347: D3623.diff
Sat, Jan 4, 12:49
Unknown Object (File)
Sat, Jan 4, 02:10
Unknown Object (File)
Sat, Jan 4, 02:08
Unknown Object (File)
Sat, Jan 4, 02:08
Unknown Object (File)
Sat, Jan 4, 02:07
Unknown Object (File)
Fri, Jan 3, 20:38
Unknown Object (File)
Fri, Jan 3, 08:43
Subscribers
None
Tokens
"Evil Spooky Haunted Tree" token, awarded by dereckson.

Details

Summary

This will permit to manage devcentral configuration easily

Ref T2099

Test Plan

salt docker-002 state.sls_id /srv/phabricator/devcentral/conf/local/local.json roles/paas-docker/containers/phabricator

Diff Detail

Repository
rOPS Nasqueron Operations
Lint
Lint Errors
SeverityLocationCodeMessage
Errorroles/paas-docker/containers/files/phabricator/devcentral/config.json:9JSON1Parse Error
Unit
No Test Coverage
Branch
localConfigDevcentral
Build Status
Buildable 5782
Build 6064: arc lint + arc unit

Event Timeline

DorianWinty created this revision.
dereckson requested changes to this revision.Fri, Jan 3, 11:40
dereckson added inline comments.
roles/paas-docker/containers/files/phabricator/devcentral/config.json
2

We can reuse all the first line from usual template.

9

we can rename the file config.json.jinja (in our repo) to avoid lint

53

I would add blank lines for different first words:

phabricator.show...
phabricator.base...
<blank line>
phd....
<blank line>
pyg
<blank line>
storage
<blank line>
security

roles/paas-docker/containers/phabricator.sls
33

We can also use get_password here and store the secret under the key "password" on Vault, that's what we do with every other API key.

(I see a get_token below, that was historically for Zemke-Rhyne, credentials.get_token is an alias for credentials.get_password)

This revision now requires changes to proceed.Fri, Jan 3, 11:40

I like it, that's a good step to improve automation for DevCentral container.