Page MenuHomeDevCentral
Differential D3740

Promote Type::getTypeOf as public helper method
ClosedPublic
Actions

Authored by dereckson on Oct 12 2025, 13:14.
Tags
None
Referenced Files
Unknown Object (File)
Sun, Nov 23, 02:44
Unknown Object (File)
Sun, Nov 23, 02:28
Unknown Object (File)
Sat, Nov 22, 23:21
Unknown Object (File)
Sat, Nov 22, 16:02
Unknown Object (File)
Sat, Nov 22, 15:30
Unknown Object (File)
Sat, Nov 22, 10:29
Unknown Object (File)
Fri, Nov 21, 19:47
Unknown Object (File)
Fri, Nov 21, 15:19
View All 46 Files
Subscribers
None

Details

Reviewers
dereckson
Commits
rKOTc2e2e3391db6: Promote Type::getTypeOf as public helper method
rKERUALD48ed7a8e2753: Promote Type::getTypeOf as public helper method
Summary

Plan is to add Option after Result,
so first use case will be OmniTools internally.

Test Plan
  • tests for Result still pass
  • new test for Type::getTypeOf

Diff Detail

Repository
rKERUALD Keruald libraries development repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

dereckson requested review of this revision.Oct 12 2025, 13:14
dereckson created this revision.
Harbormaster completed remote builds in B5995: Diff 9673.Oct 12 2025, 13:14
dereckson added a comment.Oct 12 2025, 13:16
$ arc unit                                              
   PASS    2ms★  Keruald.OmniTools.Tests.Reflection.TypeTest.testGetTypeOf with data set #0
   PASS   <1ms★  Keruald.OmniTools.Tests.Reflection.TypeTest.testGetTypeOf with data set #1
   PASS   <1ms★  Keruald.OmniTools.Tests.Reflection.TypeTest.testGetTypeOf with data set #2
   PASS    5ms★  Keruald.OmniTools.Tests.DataTypes.Result.OkTest.testIsOk
   PASS   <1ms★  Keruald.OmniTools.Tests.DataTypes.Result.OkTest.testIsError
   PASS   <1ms★  Keruald.OmniTools.Tests.DataTypes.Result.OkTest.testGetValue
   PASS   <1ms★  Keruald.OmniTools.Tests.DataTypes.Result.OkTest.testSetValue
   PASS   <1ms★  Keruald.OmniTools.Tests.DataTypes.Result.OkTest.testSetValueWhenTypeIsMutated
   PASS   <1ms★  Keruald.OmniTools.Tests.DataTypes.Result.OkTest.testMap
   PASS   <1ms★  Keruald.OmniTools.Tests.DataTypes.Result.OkTest.testMapErr
   PASS   <1ms★  Keruald.OmniTools.Tests.DataTypes.Result.OkTest.testOrElse
dereckson accepted this revision.Oct 12 2025, 13:16
This revision is now accepted and ready to land.Oct 12 2025, 13:16
This revision was landed with ongoing or failed builds.Oct 12 2025, 13:17
Closed by commit rKERUALD48ed7a8e2753: Promote Type::getTypeOf as public helper method (authored by dereckson). · Explain Why
This revision was automatically updated to reflect the committed changes.
dereckson added a commit: rKERUALD48ed7a8e2753: Promote Type::getTypeOf as public helper method.
dereckson added a commit: rKOTc2e2e3391db6: Promote Type::getTypeOf as public helper method.Oct 12 2025, 13:47

Revision Contents
Changeset List

PathSize
omnitools/
src/
DataTypes/
Result/
15 lines
Reflection/
17 lines
tests/
Reflection/
27 lines

Diff 9674

View Options

omnitools/src/DataTypes/Result/Ok.php

Loading...
View Options

omnitools/src/Reflection/Type.php

Loading...
View Options

omnitools/tests/Reflection/TypeTest.php

Loading...
Nasqueron DevCentral · If it had been much bigger the moon would have had a core of ice. · Powered by Phabricator