Allow make to build on FreeBSD natively
ClosedPublic
Actions

Authored by dereckson on Sat, Feb 7, 12:36.

Details

Reviewers

dereckson

Commits

rFBSQLfda64dc4e58a: Allow make to build on FreeBSD natively

Summary

mysql-config allow to easily get compiler options to find MySQL or MariaDB
include files, or libraries and options to link with the client library.

Paths for TCL includes and library are for Solaris and FreeBSD.
As far as we know, we're the only users from that library copy of the code.
If there is a need to use it from Linux, we'll need to adapt TCL directories too.

Finally, we also need to include /usr/lib for libz, as it's part of the base OS.

-G is replaced by -shared to target FreeBSD as default OS instead of Solaris.

Changes are compatible with both BSD and GNU Make.

Test Plan

make
gmake

Diff Detail

Repository

rFBSQL fbsql

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

dereckson requested review of this revision.Sat, Feb 7, 12:36

dereckson created this revision.

Harbormaster completed remote builds in B6244: Diff 10137.Sat, Feb 7, 12:36

Note we don't have an error handling if mysql_config fails, but that would mainly mean MySQL client library isn't installed (or the -dev/-devel package on Linux distros).

That's normally a job for ./configure step to ensure prerequisites are there.

This revision is now accepted and ready to land.Sat, Feb 7, 12:44

Closed by commit rFBSQLfda64dc4e58a: Allow make to build on FreeBSD natively (authored by dereckson). · Explain WhySat, Feb 7, 12:46

This revision was automatically updated to reflect the committed changes.

dereckson added a commit: rFBSQLfda64dc4e58a: Allow make to build on FreeBSD natively.

dereckson mentioned this in T2213: Ensure fbsql still compile with C23 standard.Sat, Feb 7, 12:54