Retrieve CARP configuration for a specific node
ClosedPublic
Actions

Authored by yousra on Thu, Feb 26, 12:41.

Details

Reviewers

dereckson
Duranzed

Maniphest Tasks

T2264: Implement CARP configuration for router-002 and router-003

Commits

rOPS94c511d9b468: Retrieve CARP configuration for a specific node

Summary

Introduce a new helper function get_carp_entries() to retrieve CARP
configuration entries from pillar network data.

The function iterates over interfaces, filters FHRP entries using
the "carp" protocol, and returns structured and ordered data including:

device (interface name)
vhid
vip
advskew (defaulting to 0 when not specified)

Ref T2264

Test Plan

Added unit tests for get_carp_entries to validate:

correct extraction of CARP entries when present, ignoring non-CARP FHRP entries
proper handling of empty FHRP lists

Executed the tests and confirmed all tests pass

Diff Detail

Repository

rOPS Nasqueron Operations

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

yousra requested review of this revision.Thu, Feb 26, 12:41

yousra created this revision.

Harbormaster completed remote builds in B6375: Diff 10324.Thu, Feb 26, 12:41

yousra added reviewers: dereckson, Duranzed.Thu, Feb 26, 12:42

I added a test to determine if the function get_carp_entries() will avoid an FHRP group
if it's not the CARP protocol. Also, it is more readable if we place the CARP configuration directly in the forest.yaml.

Harbormaster completed remote builds in B6376: Diff 10325.Thu, Feb 26, 13:31

yousra edited the summary of this revision. (Show Details)Thu, Feb 26, 13:39

yousra added a task: T2264: Implement CARP configuration for router-002 and router-003 .

yousra mentioned this in T2264: Implement CARP configuration for router-002 and router-003 .Thu, Feb 26, 14:16

dereckson accepted this revision.Wed, Mar 4, 07:29

dereckson retitled this revision from add helper get_carp_entries() to _modules/node.py and unit tests to Retrieve CARP configuration for a specific node.

dereckson edited the summary of this revision. (Show Details)

dereckson edited the test plan for this revision. (Show Details)

This revision is now accepted and ready to land.Wed, Mar 4, 07:29

yousra edited the test plan for this revision. (Show Details)Thu, Mar 5, 14:35

Closed by commit rOPS94c511d9b468: Retrieve CARP configuration for a specific node (authored by yousra). · Explain WhyThu, Mar 5, 14:54

This revision was automatically updated to reflect the committed changes.

yousra added a commit: rOPS94c511d9b468: Retrieve CARP configuration for a specific node.