Page MenuHomeDevCentral

Simplify autochmod-git
ClosedPublic

Authored by dereckson on Fri, Mar 6, 19:29.
Tags
None
Referenced Files
Unknown Object (File)
Thu, Mar 26, 18:54
Unknown Object (File)
Thu, Mar 26, 10:06
Unknown Object (File)
Thu, Mar 26, 10:06
Unknown Object (File)
Thu, Mar 26, 10:06
Unknown Object (File)
Thu, Mar 26, 10:06
Unknown Object (File)
Thu, Mar 26, 10:06
Unknown Object (File)
Thu, Mar 26, 10:06
Unknown Object (File)
Mon, Mar 23, 22:37
Subscribers
None

Details

Summary

This is a follow-up for 7d91908d.

Test Plan

Tested on Complector on /opt/salt/nasqueron-operations

Diff Detail

Repository
rOPS Nasqueron Operations
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

dereckson created this revision.

About shellcheck linter issues.

As documented in the commit message, we trade whitespace security to straightforward convenience knowing we don't use space in file names.

As such, we want to use space for word splitting in the output of find command, space is a valid separator between files in our repository.

I've discovered X option in chmod that solves the issue nicely, by setting executable bit only where needed (already executable files and directories), so we can keep the find approach and stay safe for whitespaces.

dereckson retitled this revision from Use directly find without xargs to fix repository permissions to Simplify autochmod-git.Fri, Mar 6, 19:50
dereckson edited the summary of this revision. (Show Details)
dereckson edited the test plan for this revision. (Show Details)
This revision is now accepted and ready to land.Sun, Mar 8, 22:07
This revision was automatically updated to reflect the committed changes.