Page MenuHomeDevCentral

Provide a Docker image able to run tests
Needs ReviewPublic

Authored by dereckson on Sun, Mar 22, 13:57.
Tags
None
Referenced Files
Unknown Object (File)
Sun, Apr 12, 20:50
Unknown Object (File)
Wed, Apr 8, 16:10
Unknown Object (File)
Mon, Apr 6, 02:44
Unknown Object (File)
Fri, Apr 3, 03:45
Unknown Object (File)
Thu, Apr 2, 03:46
Unknown Object (File)
Wed, Apr 1, 17:32
Unknown Object (File)
Tue, Mar 31, 07:13
Unknown Object (File)
Mon, Mar 30, 19:03
Subscribers
None

Details

Summary

This image is intended to be run by contributors or as Jenkins agent.

For contributors local workflow, a run script is provided, with a similar
logic to our Arcanist wrapper: it creates an image running with a uid similar
to local user.

Salt is installed through upstream package. Python dependencies are installed
from requirements.txt. To build the image, a Makefile script is provided.

The image isn't a full development workspace: it doesn't provide editors
like vim or nano.

Ref T2283

Test Plan
  • Build image
  • Run image locally, with tests, on Debian and Fedora

Diff Detail

Repository
rOPS Nasqueron Operations
Lint
Lint Warnings
SeverityLocationCodeMessage
Warningutils/docker/run.sh:47SC2164SHELLCHECK
Warningutils/docker/run.sh:69SC2046SHELLCHECK
Adviceutils/docker/run.sh:52SC2086SHELLCHECK
Adviceutils/docker/run.sh:59SC2086SHELLCHECK
Adviceutils/docker/run.sh:64SC2086SHELLCHECK
Unit
No Test Coverage
Branch
docker-jenkins-agent
Build Status
Buildable 6518
Build 6802: arc lint + arc unit

Event Timeline

dereckson created this revision.

I tested the Docker image locally and the image builds, the container starts correctly, and the test suite runs inside it.

However, one test currently fails:
test_get_rustc_triplet in _tests/modules/test_rust.py

I also got a warning from run.sh because UID is a read-only shell variable in bash.