Page MenuHomeDevCentral
Differential D4145

Validate salt-tower pillar files with JSON Schema
Changes PlannedPublic
Actions

Authored by dereckson on Wed, Aug 5, 07:15.

Details

Reviewers
None
Summary

JSON Schema has been selected to offer validation in IDE.

The pillar files we validate are the pillar defined in tower.sls,
as we create new files for new servers or services.

Test Plan
  • New tests pass

Diff Detail

Repository
rOPS Nasqueron Operations
Lint
Lint Errors
SeverityLocationCodeMessage
Error_tests/pillar/dbserver/test_postgresql.py:78E501flake8 E501
Unit
No Test Coverage
Branch
codex-pillar-tests
Build Status
Buildable 6779
Build 7067: arc lint + arc unit

Event Timeline

dereckson requested review of this revision.Wed, Aug 5, 07:15
dereckson created this revision.
Harbormaster completed remote builds in B6779: Diff 10872.Wed, Aug 5, 07:15
dereckson planned changes to this revision.Wed, Aug 5, 07:18

I wonder if T1681 couldn't host them too. If so:

"$id": "https://operations.nasqueron.org/schemas/pillar/certificates.schema.json",

should become:

"$id": "https://schema.nasqueron.org/operations/pillar/certificates.schema.json",
dereckson awarded a token.Wed, Aug 5, 07:18

Models used:

  • GPT 5.5 (Codex, from JetBrains PyCharm) for the schema generation and the tests
  • Qwen 3.8 for code review

Revision Contents
Changeset List

PathSize
.vscode/
25 lines
2 lines
_resources/
schemas/
pillar/
43 lines
306 lines
34 lines
21 lines
220 lines
149 lines
18 lines
_tests/
pillar/
core/
24 lines
dbserver/
12 lines
dns/
1 line
24 lines
paas/
24 lines
7 lines
saas/
1 line
24 lines
137 lines
webserver/
1 line
27 lines
1 line

Diff 10872

View Options

.vscode/settings.json

Loading...
View Options

README.md

Loading...
View Options

_resources/schemas/pillar/certificates.schema.json

Loading...
View Options

_resources/schemas/pillar/dbserver.schema.json

Loading...
View Options

_resources/schemas/pillar/dns.schema.json

Loading...
View Options

_resources/schemas/pillar/nextcloud.schema.json

Loading...
View Options

_resources/schemas/pillar/paas-alkane.schema.json

Loading...
View Options

_resources/schemas/pillar/paas-docker.schema.json

Loading...
View Options

_resources/schemas/pillar/webserver.schema.json

Loading...
View Options

_tests/pillar/core/test_certificates_schema.py

Loading...
View Options

_tests/pillar/dbserver/test_postgresql.py

Loading...
View Options

_tests/pillar/dns/__init__.py

Loading...
View Options

_tests/pillar/dns/test_schema.py

Loading...
View Options

_tests/pillar/paas/test_alkane_schema.py

Loading...
View Options

_tests/pillar/paas/test_docker.py

Loading...
View Options

_tests/pillar/saas/__init__.py

Loading...
View Options

_tests/pillar/saas/test_nextcloud_schema.py

Loading...
View Options

_tests/pillar/schema_helpers.py

Loading...
View Options

_tests/pillar/webserver/__init__.py

Loading...
View Options

_tests/pillar/webserver/test_schema.py

Loading...
View Options

requirements.txt

Loading...
Nasqueron DevCentral · If it had been much bigger the moon would have had a core of ice. · Powered by Phabricator