Page MenuHomeDevCentral

Localisation for create_surname and create_given_name (part 2)
ClosedPublic

Authored by dereckson on Jul 9 2016, 19:20.

Details

Summary

These scripts now actually use the localisation provided.

This is a follow-up for 66c0b27797dd. Fixes T892.

Side edit: import statements by alphabetical order.

Test Plan

Diff Detail

Repository
rDWD Dæghrefn Wikidata access layer
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

dereckson updated this revision to Diff 1144.Jul 9 2016, 19:20
dereckson retitled this revision from to .+prenom/.+nom: use localized labels.
dereckson updated this object.
dereckson edited the test plan for this revision. (Show Details)
dereckson added reviewers: Ash-Crow, dachary.
dereckson retitled this revision from .+prenom/.+nom: use localized labels to Localisation for create_surname and create_given_name (part 2).Jul 9 2016, 19:22
dereckson updated this object.
dachary accepted this revision.Jul 10 2016, 08:13
dachary edited edge metadata.

It would be nice to have a comment explaining what is expected in the json files, although it's fairly easy to infer by reading the source. As it's getting more sophisticated, unit tests would also be welcome.

Other than this, the code looks good and the feature useful :-)

This revision is now accepted and ready to land.Jul 10 2016, 08:13
This revision was automatically updated to reflect the committed changes.