Differential D488

Fix getItemProjectsPHIDs null exception
ClosedPublic
Actions

Authored by dereckson on Jul 11 2016, 02:20.

Details

Reviewers

dereckson

Maniphest Tasks

T916: Trying to get property of non-object in PhabricatorStory::getItemProjectsPHIDs method

Commits

rNOTIFf1e56313d6e9: Fix getItemProjectsPHIDs null exception

Summary

Phabricator API can sometimes return an empty array.
In such case, we don't have any projects to return.

This fix the following issue:
Trying to get property of non-object in
PhabricatorStory::getItemProjectsPHIDs method

Fixes T916.

Test Plan

Fire again the failed notification.

Diff Detail

Repository

rNOTIF Notifications center

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

dereckson updated this revision to Diff 1185.Jul 11 2016, 02:20

dereckson added a task: T916: Trying to get property of non-object in PhabricatorStory::getItemProjectsPHIDs method.

dereckson retitled this revision from to Fix getItemProjectsPHIDs null exception.

dereckson updated this object.

dereckson edited the test plan for this revision. (Show Details)

dereckson added a reviewer: dereckson.

Looks good to me:

02:06:35 < Wearg> dereckson shifted T789: Rename Kal*i*x in Sandlayth from the S1 Nasqueron space to the S2 Nasqueron internal space.

This revision is now accepted and ready to land.Jul 11 2016, 02:25

Closed by commit rNOTIFf1e56313d6e9: Fix getItemProjectsPHIDs null exception (authored by dereckson, committed by dereckson). · Explain WhyJul 11 2016, 02:26

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

app/

Phabricator/

PhabricatorStory.php

4 lines

Diff 1186

View Options

app/Phabricator/PhabricatorStory.php

Fix getItemProjectsPHIDs null exceptionClosedPublicActions