Differential D530

Handle watch event (star) on GitHub
ClosedPublic
Actions

Authored by dereckson on Jul 21 2016, 22:30.

Details

Reviewers

dereckson

Maniphest Tasks

T932: Handle GitHub watch event

Commits

rNOTIF03f1df78a0e9: Handle watch event (star) on GitHub

Summary

The watch event occurs when an user stars a repository.

The current star action on GitHub was the former watch,
and to avoid to break compatibility, the former name
remained.

Fixes T932.

Test Plan

Unit test with the payload from API doc
Fire a payload received for Nasqueron 22:27:04 < Wearg> shaung starred nasqueron/docker-phabricator — https://github.com/shaung

Diff Detail

Repository

rNOTIF Notifications center

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

dereckson updated this revision to Diff 1292.Jul 21 2016, 22:30

dereckson added a task: T932: Handle GitHub watch event.

dereckson retitled this revision from to Handle watch event (star) on GitHub The watch event occurs when an user stars a repository. The current star action on GitHub was the former watch, and to avoid to break compatibility, the former name remained..

dereckson updated this object.

dereckson edited the test plan for this revision. (Show Details)

dereckson added a reviewer: dereckson.Jul 21 2016, 22:32

Update spacing

dereckson accepted this revision.Jul 21 2016, 22:35

dereckson retitled this revision from Handle watch event (star) on GitHub The watch event occurs when an user stars a repository. The current star action on GitHub was the former watch, and to avoid to break compatibility, the former name remained. to Handle watch event (star) on GitHub.

dereckson updated this object.

dereckson edited edge metadata.

This revision is now accepted and ready to land.Jul 21 2016, 22:35

Closed by commit rNOTIF03f1df78a0e9: Handle watch event (star) on GitHub (authored by dereckson, committed by dereckson). · Explain WhyJul 21 2016, 22:36

This revision was automatically updated to reflect the committed changes.

Build is green https://ci.nasqueron.org/job/test-notifications-phab/137/ for more details.