Page MenuHomeDevCentral
Differential D531

Refactor PhabricatorListener
ClosedPublic
Actions

Authored by dereckson on Jul 22 2016, 02:32.
Tags
None
Referenced Files
F3327489: D531.id1295.diff
Mon, Jul 8, 15:22
F3325234: D531.id1297.diff
Mon, Jul 8, 07:03
Unknown Object (File)
Sun, Jul 7, 14:14
Unknown Object (File)
Sun, Jul 7, 06:46
Unknown Object (File)
Sat, Jul 6, 00:38
Unknown Object (File)
Thu, Jul 4, 12:09
Unknown Object (File)
Thu, Jul 4, 11:29
Unknown Object (File)
Thu, Jul 4, 06:52
View All Files
Subscribers
None

Details

Reviewers
dereckson
Maniphest Tasks
T851: Map GitHub gates to Phabricator instances
Commits
rNOTIF2e891d6b73fc: Refactor PhabricatorListener
Summary

This change moves the responsibility to perform the task
from the event listener to a dedicated job class.

The job class NotifyNewCommitsToDiffusion allows to call the
Phabricator API for any repository, not only for GitHub ones.

As a preparation for T851, we provide a getPhabricatorProject
method to allow to map source project and Phabricator project.

Ref. T851.

Test Plan
  • With artisan tinker, prepare a notification for rTOMMY
  • Minimal test to check job wants a Phabricator API

Diff Detail

Repository
rNOTIF Notifications center
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

dereckson updated this revision to Diff 1295.Jul 22 2016, 02:32
dereckson added a task: T851: Map GitHub gates to Phabricator instances.
dereckson retitled this revision from to Refactor PhabricatorListener.
dereckson updated this object.
dereckson edited the test plan for this revision. (Show Details)
dereckson added a reviewer: dereckson.
dereckson planned changes to this revision.Jul 22 2016, 02:34
dereckson added inline comments.
app/Jobs/NotifyNewCommitsToDiffusion.php
148

This block should be before helper methods, as the class is rather dense.

tests/Jobs/NotifyNewCommitsToDiffusionTest.php
45

\n

dereckson updated this revision to Diff 1296.Jul 22 2016, 02:36
dereckson marked 2 inline comments as done.
dereckson edited edge metadata.

Per previous comment

dereckson accepted this revision.Jul 22 2016, 02:37
dereckson edited edge metadata.
This revision is now accepted and ready to land.Jul 22 2016, 02:37
Closed by commit rNOTIF2e891d6b73fc: Refactor PhabricatorListener (authored by dereckson, committed by dereckson). · Explain WhyJul 22 2016, 02:38
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
app/
Jobs/
195 lines
Listeners/
75 lines
tests/
Jobs/
44 lines

Diff 1297

View Options

app/Jobs/NotifyNewCommitsToDiffusion.php

Loading...
View Options

app/Listeners/PhabricatorListener.php

Loading...
View Options

tests/Jobs/NotifyNewCommitsToDiffusionTest.php

Loading...
Nasqueron DevCentral · If it had been much bigger the moon would have had a core of ice. · Powered by Phabricator